From: Frederik Deweerdt <deweerdt@free.fr>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
"Andrew J. Barr" <andrew.james.barr@gmail.com>,
linux-kernel@vger.kernel.org, Jan Beulich <jbeulich@novell.com>,
Andi Kleen <ak@suse.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
walt <w41ter@gmail.com>
Subject: Re: [-mm patch] ptrace: Fix EFL_OFFSET value according to i386 pda changes (was Re: BUG on 2.6.20-rc1 when using gdb)
Date: Wed, 20 Dec 2006 21:07:36 +0000 [thread overview]
Message-ID: <20061220210736.GC28900@slug> (raw)
In-Reply-To: <4589A2CD.2020108@goop.org>
On Wed, Dec 20, 2006 at 12:53:33PM -0800, Jeremy Fitzhardinge wrote:
> Frederik Deweerdt wrote:
> > It works too, thanks. BTW, I wondered if the "case GS:" in getreg() made
> > sense now?
>
> Sorry, what do you mean? It looks OK to me, but I'm not sure what
> you're referring to.
My bad, that's the code I'm referring to:
121 static unsigned long getreg(struct task_struct *child,
122 unsigned long regno)
[...]
126 switch (regno >> 2) {
127 case GS:
128 retval = child->thread.gs;
129 break;
What seem weird to me is that putreg(GS) will end up putting 'value' in:
child->thread.esp0 - sizeof(struct pt_regs) + (GS - 1)*4
whereas getreg(GS) will return the value of child->thread.gs
I must miss something, but the symetry seemed odd to me.
Regards,
Frederik
>
> J
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2006-12-20 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 1:55 BUG on 2.6.20-rc1 when using gdb Andrew J. Barr
2006-12-20 0:42 ` Andrew Morton
2006-12-20 0:53 ` Dave Airlie
2006-12-20 0:54 ` Dave Airlie
2006-12-20 11:21 ` Jeremy Fitzhardinge
2006-12-20 18:35 ` [-mm patch] ptrace: Fix EFL_OFFSET value according to i386 pda changes (was Re: BUG on 2.6.20-rc1 when using gdb) Frederik Deweerdt
2006-12-20 19:02 ` Andrew J. Barr
2006-12-20 19:21 ` Jeremy Fitzhardinge
2006-12-20 20:37 ` walt
2006-12-20 20:42 ` Frederik Deweerdt
2006-12-20 20:53 ` Jeremy Fitzhardinge
2006-12-20 21:07 ` Frederik Deweerdt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061220210736.GC28900@slug \
--to=deweerdt@free.fr \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=andrew.james.barr@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w41ter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox