From: Frederik Deweerdt <deweerdt@free.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, jeremy@goop.org
Subject: [-mm patch] ptrace: make {put,get}reg work again for gs and fs
Date: Thu, 21 Dec 2006 18:35:18 +0000 [thread overview]
Message-ID: <20061221183518.GA18827@slug> (raw)
In-Reply-To: <20061214225913.3338f677.akpm@osdl.org>
On Thu, Dec 14, 2006 at 10:59:13PM -0800, Andrew Morton wrote:
> http://userweb.kernel.org/~akpm/2.6.20-rc1-mm1/
>
Hi all,
Following the i386 pda patches, it's not possible to set gs or fs value
from gdb anymore. The following patch restores the old behaviour of
getting and setting thread.gs of thread.fs respectively.
Here's a gdb session *before* the patch:
(gdb) info reg
[...]
fs 0x33 51
gs 0x33 51
(gdb) set $fs=0xffff
(gdb) info reg
[...]
fs 0x33 51
gs 0x33 51
(gdb) set $gs=0xffffffff
(gdb) info reg
[...]
fs 0xffff 65535
gs 0x33 51
Another one *after* the patch:
(gdb) info reg
[...]
fs 0xd8 216
gs 0x33 51
(gdb) set $fs=0xffff
(gdb) info reg
[...]
fs 0xffff 65535
gs 0x33 51
(gdb) set $gs=0xffff
(gdb) info reg
[...]
fs 0xffff 65535
gs 0xffff 65535
Andrew, this goes on top of ptrace-fix-efl_offset-value-according-to-i386-pda-changes.patch
sent by Jeremy yesterday.
Regards,
Frederik
Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
diff --git a/arch/i386/kernel/ptrace.c b/arch/i386/kernel/ptrace.c
index a803a49..7af494e 100644
--- a/arch/i386/kernel/ptrace.c
+++ b/arch/i386/kernel/ptrace.c
@@ -94,9 +94,13 @@ static int putreg(struct task_struct *child,
return -EIO;
child->thread.fs = value;
return 0;
+ case GS:
+ if (value && (value & 3) != 3)
+ return -EIO;
+ child->thread.gs = value;
+ return 0;
case DS:
case ES:
- case GS:
if (value && (value & 3) != 3)
return -EIO;
value &= 0xffff;
@@ -124,12 +128,14 @@ static unsigned long getreg(struct task_struct *child,
unsigned long retval = ~0UL;
switch (regno >> 2) {
+ case FS:
+ retval = child->thread.fs;
+ break;
case GS:
retval = child->thread.gs;
break;
case DS:
case ES:
- case FS:
case SS:
case CS:
retval = 0xffff;
next prev parent reply other threads:[~2006-12-21 18:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 6:59 2.6.20-rc1-mm1 Andrew Morton
2006-12-15 6:59 ` BUG: NMI Watchdog detected LOCKUP (was: 2.6.20-rc1-mm1) Tilman Schmidt
2006-12-19 18:52 ` Thomas Gleixner
2006-12-19 19:56 ` [patch] hrtimers: add state tracking, fix Ingo Molnar
2006-12-20 1:38 ` Tilman Schmidt
2006-12-20 20:05 ` Tilman Schmidt
2006-12-15 14:46 ` OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-15 19:24 ` Andrew Morton
2006-12-15 22:49 ` Jiri Slaby
2006-12-15 20:39 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-15 21:01 ` 2.6.20-rc1-mm1 Andrew Morton
2006-12-17 11:07 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-18 8:03 ` 2.6.20-rc1-mm1 Laurent Riffard
2006-12-18 18:35 ` 2.6.20-rc1-mm1 Damien Wyart
2006-12-19 23:29 ` 2.6.20-rc1-mm1 Luben Tuikov
2006-12-18 7:44 ` 2.6.20-rc1-mm1 Jens Axboe
2006-12-15 23:26 ` WARNING (1) at .../arch/i386/mm/highmem.c:49 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-16 0:16 ` Andrew Morton
2006-12-16 0:04 ` 2.6.20-rc1-mm1: unused sysrq_timer_list_show() Adrian Bunk
2006-12-16 7:56 ` [patch] debugging feature: SysRq-Q to print timers Ingo Molnar
2006-12-18 23:31 ` Andrew Morton
2006-12-18 23:45 ` Dave Jones
2006-12-19 0:00 ` Andrew Morton
2006-12-19 12:01 ` Ingo Molnar
2006-12-16 12:37 ` (Cross) compiling fails on first try (was Re: 2.6.20-rc1-mm1) Jan Dittmer
2006-12-16 13:56 ` [-mm patch] drivers/ide/pci/tc86c001.c: make a function static Adrian Bunk
2006-12-16 14:18 ` Alan
2006-12-17 18:08 ` Sergei Shtylyov
2006-12-17 20:52 ` Sergei Shtylyov
2006-12-16 13:56 ` [-mm patch] make uio_irq_handler() static Adrian Bunk
2006-12-20 6:09 ` Greg KH
2006-12-16 13:56 ` [-mm patch] drivers/video/{s3fb,svgalib}.c: possible cleanups Adrian Bunk
2006-12-16 17:39 ` Randy Dunlap
2006-12-16 18:16 ` Ondrej Zajicek
2006-12-16 13:57 ` [-mm patch] mm/vmscan.c: make a function static Adrian Bunk
2006-12-16 19:30 ` [-mm patch] noinitramfs cleanup Frederik Deweerdt
2006-12-18 13:38 ` [-mm patch] kill pxa2xx Kconfig warning Frederik Deweerdt
2006-12-18 20:06 ` 2.6.20-rc1-mm1 Bartlomiej Zolnierkiewicz
2006-12-19 0:29 ` 2.6.20-rc1-mm1 Randy Dunlap
2006-12-19 0:42 ` 2.6.20-rc1-mm1 Andrew Morton
2006-12-21 18:35 ` Frederik Deweerdt [this message]
2006-12-21 19:22 ` [-mm patch] ptrace: make {put,get}reg work again for gs and fs Jeremy Fitzhardinge
2006-12-21 20:53 ` Frederik Deweerdt
2006-12-21 21:59 ` Frederik Deweerdt
2006-12-22 2:00 ` Jeremy Fitzhardinge
[not found] ` <20061221181108.6cede9ba.akpm@osdl.org>
2006-12-22 6:06 ` Frederik Deweerdt
[not found] ` <20061221225414.de09c7df.akpm@osdl.org>
2006-12-22 7:00 ` Jeremy Fitzhardinge
2006-12-22 8:05 ` Frederik Deweerdt
2006-12-22 6:52 ` Jeremy Fitzhardinge
2006-12-22 6:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061221183518.GA18827@slug \
--to=deweerdt@free.fr \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).