Re: omap compilation fixes

Tony Lindgren
2006-12-23T19:48:23Z

Hi,

* Pavel Machek <pavel@ucw.cz> [061222 13:49]:
> Hi!
>
> > > This is not yet complete set. set_map() is missing in latest kernels.
> > >
> > > Fix DECLARE_WORK()-change-related compilation problems. Please apply,
> > >
> > > --- a/drivers/mmc/omap.c
> > > +++ b/drivers/mmc/omap.c
> > > @@ -2,7 +2,7 @@
> > > * linux/drivers/media/mmc/omap.c
> > > *
> > > * Copyright (C) 2004 Nokia Corporation
> > > - * Written by Tuukka Tikkanen and Juha Yrjölä<juha.yrjola@nokia.com>
> > > + * Written by Tuukka Tikkanen and Juha Yrjölä <juha.yrjola@nokia.com>
> > > * Misc hacks here and there by Tony Lindgren <tony@atomide.com>
> > > * Other hacks (DMA, SD, etc) by David Brownell
> > > *
> >
> > I already applied similar fixes to linux-omap for the workqueue changes,
> > so I only applied the MMC typo fix above.
>
> I thought I got pretty recent -git:
>
> omap git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
>
> ...should I use another tree?
>
> Aha, I did another pull now and it seems to be better... no, it is
> not:
>
> Recovering from a previously interrupted fetch...
> Fetching pack (head and objects)...
> Fetching tags...
> Missing tag v2.6.20-rc1...
> Generating pack...
> Done counting 1 objects.
> Deltifying 1 objects.
> 100% (1/1) done
> Total 1, written 1 (delta 0), reused 1 (delta 0)
> Unpacking 1 objects
> 100% (1/1) done
> Up to date.
>
> Applying changes...
> Branch already fully merged.
>
> Plus it still does not compile:
>
> LD vmlinux
> arch/arm/plat-omap/built-in.o(.text+0xd470): In function
> `exmap_set_armmmu':
> : undefined reference to `set_pte'
> arch/arm/plat-omap/built-in.o(.text+0xd56c): In function
> `exmap_set_armmmu':
> : undefined reference to `set_pte'
> make: *** [vmlinux] Error 1

Is this still a problem? Sounds like the latest tree was not yet
mirrored from master.kernel.org when you pulled.

Regards,

Tony