From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] change WARN_ON back to "BUG: at ..."
Date: Sun, 24 Dec 2006 14:16:25 +0000 [thread overview]
Message-ID: <20061224141625.GA4071@ucw.cz> (raw)
In-Reply-To: <20061222120422.eb28953b.akpm@osdl.org>
Hi!
> I've always felt that it is wrong (or at least misleading) that WARN_ON
> prints "BUG". It would have been better if it had said "WARNING", and only
> BUG_ON says "BUG".
>
> But lots of people have now written downstream log-parsing tools which
> might break due to this change, so I'm inclined to go with Ingo's patch,
> and restore the old (il)logic.
People should not be parsing syslog. If they do, they deserve
occassional breakage.
Pavel
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2006-12-24 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 12:43 [patch] change WARN_ON back to "BUG: at ..." Ingo Molnar
2006-12-21 13:00 ` Arjan van de Ven
2006-12-21 18:49 ` Jeremy Fitzhardinge
2006-12-21 23:57 ` Ingo Molnar
2006-12-22 20:04 ` Andrew Morton
2006-12-23 2:06 ` Steven Rostedt
2006-12-23 11:03 ` Ingo Molnar
2006-12-23 12:44 ` Steven Rostedt
2006-12-24 14:16 ` Pavel Machek [this message]
2006-12-28 9:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061224141625.GA4071@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox