* [PATCH] module: fix mod_sysfs_setup() return value
@ 2006-12-25 8:15 Akinobu Mita
0 siblings, 0 replies; only message in thread
From: Akinobu Mita @ 2006-12-25 8:15 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
mod_sysfs_setup() doesn't return error when kobject_add_dir() failed.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
kernel/module.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: 2.6-mm/kernel/module.c
===================================================================
--- 2.6-mm.orig/kernel/module.c
+++ 2.6-mm/kernel/module.c
@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module
goto out;
mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
- if (!mod->drivers_dir)
+ if (!mod->drivers_dir) {
+ err = -ENOMEM;
goto out_unreg;
+ }
err = module_param_sysfs_setup(mod, kparam, num_params);
if (err)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-25 8:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-25 8:15 [PATCH] module: fix mod_sysfs_setup() return value Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox