public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Robert Crocombe <rcrocomb@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.19.1-rt15: BUG in __tasklet_action at kernel/softirq.c:568
Date: Wed, 27 Dec 2006 00:40:45 +0100	[thread overview]
Message-ID: <20061226234045.GC6003@elte.hu> (raw)
In-Reply-To: <1166671151.852.4.camel@localhost.localdomain>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 2006-12-20 at 20:50 +0100, Ingo Molnar wrote:
> > * Robert Crocombe <rcrocomb@gmail.com> wrote:
> > 
> > > On 12/19/06, Ingo Molnar <mingo@elte.hu> wrote:
> > > >yeah. This is something that triggers very rarely on certain boxes. Not
> > > >fixed yet, and it's been around for some time.
> > > 
> > > Is there anything you would like me to do to help diagnose this?
> > 
> > to figure out what the bug is :-/ Below is the tasklet redesign patch - 
> > the bug must be in there somewhere.
> 
> > +static inline int tasklet_tryunlock(struct tasklet_struct *t)
> > +{
> > +	return cmpxchg(&t->state, TASKLET_STATEF_RUN, 0) == TASKLET_STATEF_RUN;
> > +}
> > +
> 
> This probably isn't it, but is cmpxchg available on all archs now?

yeah, it's probably not related, i saw these failures on plain i686 too, 
which definitely has cmpxchg support. The failures i saw happened on a 
hyperthreading CPU, so i guess it must be some sort of narrow race.

	Ingo

      reply	other threads:[~2006-12-26 23:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18 17:48 2.6.19.1-rt15: BUG in __tasklet_action at kernel/softirq.c:568 Robert Crocombe
2006-12-19 17:57 ` Ingo Molnar
2006-12-20 12:37   ` Robert Crocombe
2006-12-20 19:50     ` Ingo Molnar
2006-12-21  3:19       ` Steven Rostedt
2006-12-26 23:40         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061226234045.GC6003@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcrocomb@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox