From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: martin@strongswan.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc1] xfrm: Algorithm lookup using .compat name
Date: Thu, 28 Dec 2006 21:28:51 -0800 (PST) [thread overview]
Message-ID: <20061228.212851.93211529.davem@davemloft.net> (raw)
In-Reply-To: <20061222210446.GB22568@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 23 Dec 2006 08:04:46 +1100
> On Fri, Dec 22, 2006 at 05:26:43PM +0100, Martin Willi wrote:
> > Installing an IPsec SA using old algorithm names (.compat) does not work
> > if the algorithm is not already loaded. When not using the PF_KEY
> > interface, algorithms are not preloaded in xfrm_probe_algs() and
> > installing a IPsec SA fails.
>
> Good catch. Thanks Martin!
Applied.
Martin, please be careful with future patch submissions, your
email client corrupted up the patch by adding newlines and
changing tab characters into spaces, so I had to add the patch
by hand.
Herbert, this fix is only needed for 2.6.20 correct? I assume
it was added by the 2.6.20 crypto layer merge, right?
Thanks.
next prev parent reply other threads:[~2006-12-29 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 16:26 [PATCH 2.6.20-rc1] xfrm: Algorithm lookup using .compat name Martin Willi
2006-12-22 21:04 ` Herbert Xu
2006-12-29 5:28 ` David Miller [this message]
2006-12-29 9:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228.212851.93211529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox