From: Ingo Molnar <mingo@elte.hu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] change WARN_ON back to "BUG: at ..."
Date: Thu, 28 Dec 2006 10:15:48 +0100 [thread overview]
Message-ID: <20061228091548.GA24765@elte.hu> (raw)
In-Reply-To: <20061224141625.GA4071@ucw.cz>
* Pavel Machek <pavel@ucw.cz> wrote:
> > But lots of people have now written downstream log-parsing tools
> > which might break due to this change, so I'm inclined to go with
> > Ingo's patch, and restore the old (il)logic.
>
> People should not be parsing syslog. If they do, they deserve
> occassional breakage.
so what other method do you propose to those who are working on
increasing the reliability of the kernel by running automatic regression
tests and boot allyesconfig kernels, to figure out whether out of the
tons of kernel logs there was any problem? Right now "^BUG: " is a
pretty universal filter, and i dont see a problem in preserving that.
(for lockdep there's a 'debug_locks' line in /proc/lockdep_stats that
tells us whether any lock related assert was printed by the kernel, and
my scripts monitor that. Along that line we could introduce a
/proc/sys/kernel/bugs counter for tools to monitor. But even after that,
you have to find the place in the syslog so having a text signature for
kernel bugs is still a good idea.)
Ingo
prev parent reply other threads:[~2006-12-28 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 12:43 [patch] change WARN_ON back to "BUG: at ..." Ingo Molnar
2006-12-21 13:00 ` Arjan van de Ven
2006-12-21 18:49 ` Jeremy Fitzhardinge
2006-12-21 23:57 ` Ingo Molnar
2006-12-22 20:04 ` Andrew Morton
2006-12-23 2:06 ` Steven Rostedt
2006-12-23 11:03 ` Ingo Molnar
2006-12-23 12:44 ` Steven Rostedt
2006-12-24 14:16 ` Pavel Machek
2006-12-28 9:15 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228091548.GA24765@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox