From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Tim Schmielau <tim@physik3.uni-rostock.de>,
lkml <linux-kernel@vger.kernel.org>,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] remove 556 unneeded #includes of sched.h
Date: Thu, 28 Dec 2006 12:58:05 -0800 [thread overview]
Message-ID: <20061228125805.2edc0a2b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20061228124644.4e1ed32b.akpm@osdl.org>
On Thu, 28 Dec 2006 12:46:44 -0800 Andrew Morton wrote:
> On Thu, 28 Dec 2006 21:27:40 +0100 (CET)
> Tim Schmielau <tim@physik3.uni-rostock.de> wrote:
>
> > After Al Viro (finally) succeeded in removing the sched.h #include in
> > module.h recently, it makes sense again to remove other superfluous
> > sched.h includes.
>
> Why are they "superfluous"? Because those compilation
> units pick up sched.h indirectly, via other includes?
I'm half done with a patch to remove includes of smp_lock.h.
For the files that I have patched, I checked each source file
for all interfaces in smp_lock.h to verify that none of them
are used, so the #include is just waste.
> If so, is that a thing we want to do?
Nope.
---
~Randy
next prev parent reply other threads:[~2006-12-28 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 20:27 [PATCH] remove 556 unneeded #includes of sched.h Tim Schmielau
2006-12-28 20:36 ` Tim Schmielau
2006-12-28 20:46 ` Andrew Morton
2006-12-28 20:58 ` Randy Dunlap [this message]
2006-12-28 21:10 ` Tim Schmielau
2006-12-28 20:58 ` Tim Schmielau
2006-12-28 21:08 ` Al Viro
2006-12-28 21:18 ` Tim Schmielau
2006-12-28 21:34 ` Russell King
2006-12-28 21:32 ` Randy Dunlap
2006-12-28 21:48 ` Russell King
2006-12-28 21:53 ` Tim Schmielau
2006-12-28 22:23 ` Russell King
2006-12-28 22:27 ` Tim Schmielau
2006-12-29 0:10 ` Randy Dunlap
2006-12-29 0:37 ` Tim Schmielau
2006-12-29 0:31 ` Randy Dunlap
2006-12-29 10:40 ` Tim Schmielau
2006-12-28 21:42 ` Tim Schmielau
2006-12-29 10:23 ` [updated PATCH] remove 555 " Tim Schmielau
2006-12-29 10:43 ` Tim Schmielau
2006-12-30 17:19 ` Russell King
2007-01-23 6:15 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228125805.2edc0a2b.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@physik3.uni-rostock.de \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox