From: Al Viro <viro@ftp.linux.org.uk>
To: Tim Schmielau <tim@physik3.uni-rostock.de>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove 556 unneeded #includes of sched.h
Date: Thu, 28 Dec 2006 21:08:03 +0000 [thread overview]
Message-ID: <20061228210803.GR17561@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.63.0612282154460.20531@gockel.physik3.uni-rostock.de>
On Thu, Dec 28, 2006 at 09:58:17PM +0100, Tim Schmielau wrote:
> On Thu, 28 Dec 2006, Andrew Morton wrote:
>
> > On Thu, 28 Dec 2006 21:27:40 +0100 (CET)
> > Tim Schmielau <tim@physik3.uni-rostock.de> wrote:
> >
> > > After Al Viro (finally) succeeded in removing the sched.h #include in
> > > module.h recently, it makes sense again to remove other superfluous
> > > sched.h includes.
> >
> > Why are they "superfluous"? Because those compilation
> > units pick up sched.h indirectly, via other includes?
> >
> > If so, is that a thing we want to do?
>
> No, there is nothing at all in these files that needs sched.h. I suppose
> the includes are left over from times when more unrelated macros lived in
> sched.h (fortunately much of that cruft got cleand up already).
Uh-huh. How much of build coverage have you got with it? Note that
"doesn't use symbols defined in sched.h" != "can remove include of
sched.h", which, in turn, is not the same as "removing it doesn't
cause problems on a couple of configs I've tried on amd64".
next prev parent reply other threads:[~2006-12-28 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 20:27 [PATCH] remove 556 unneeded #includes of sched.h Tim Schmielau
2006-12-28 20:36 ` Tim Schmielau
2006-12-28 20:46 ` Andrew Morton
2006-12-28 20:58 ` Randy Dunlap
2006-12-28 21:10 ` Tim Schmielau
2006-12-28 20:58 ` Tim Schmielau
2006-12-28 21:08 ` Al Viro [this message]
2006-12-28 21:18 ` Tim Schmielau
2006-12-28 21:34 ` Russell King
2006-12-28 21:32 ` Randy Dunlap
2006-12-28 21:48 ` Russell King
2006-12-28 21:53 ` Tim Schmielau
2006-12-28 22:23 ` Russell King
2006-12-28 22:27 ` Tim Schmielau
2006-12-29 0:10 ` Randy Dunlap
2006-12-29 0:37 ` Tim Schmielau
2006-12-29 0:31 ` Randy Dunlap
2006-12-29 10:40 ` Tim Schmielau
2006-12-28 21:42 ` Tim Schmielau
2006-12-29 10:23 ` [updated PATCH] remove 555 " Tim Schmielau
2006-12-29 10:43 ` Tim Schmielau
2006-12-30 17:19 ` Russell King
2007-01-23 6:15 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061228210803.GR17561@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox