From: Willy Tarreau <w@1wt.eu>
To: Mats Erik Andersson <mats.andersson64@comhem.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Three if-clauses of constant logic value; char drivers for kernel 2.4.33.3
Date: Fri, 29 Dec 2006 23:16:40 +0100 [thread overview]
Message-ID: <20061229221639.GO24090@1wt.eu> (raw)
In-Reply-To: <1166561978.4133.26.camel@localhost.localdomain>
On Tue, Dec 19, 2006 at 09:59:37PM +0100, Mats Erik Andersson wrote:
> Hi there, all masters of kernel code,
Hi !
> I just discovered that the kernel code for 2.4.33.3 contains three
> if-statements that never can change their values, whence they should
> be repaired or eliminated. In source directory linux/drivers/char the
> files vt.c and keyboard.c produce these warning upon compilation:
>
> vt.c:166: varning: comparison is always false due to limited range
> of data type
> vt.c:289: varning: comparison is always false due to limited range
> of data type
> keyboard.c:640: varning: comparison is always true due to limited
> range of data type
>
> I did the compilation with gcc 3.3.5 on Debian Sarge. This behaviour
> appeared first for kernel 2.2.19, since I wanted to revive the old
> minirtl edition, but to my surprise the same warnings appear also
> with the brand new kernel 2.4.33.3.
OK thanks for reporting this. I'll take a look at those before next
release.
BTW, sorry, I missed your post. When posting 2.4-related mails, please
try to put the "2.4" word close to the beginning of the subject so that
my eyes can notice it in the middle of the 10000 other montly messages
on LKML.
> Best regards
> Mats Erik Andersson, PhD
> ynglingatal@yahoo.se
> mats.andersson64@comhem.se
best regards,
Willy
next prev parent reply other threads:[~2006-12-29 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 20:59 Three if-clauses of constant logic value; char drivers for kernel 2.4.33.3 Mats Erik Andersson
2006-12-29 22:16 ` Willy Tarreau [this message]
2007-02-03 10:07 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061229221639.GO24090@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=mats.andersson64@comhem.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox