From: David Miller <davem@davemloft.net>
To: rmk+lkml@arm.linux.org.uk
Cc: torvalds@osdl.org, miklos@szeredi.hu,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
akpm@osdl.org
Subject: Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again
Date: Sat, 30 Dec 2006 21:23:38 -0800 (PST) [thread overview]
Message-ID: <20061230.212338.92583434.davem@davemloft.net> (raw)
In-Reply-To: <20061230224604.GA3350@flint.arm.linux.org.uk>
From: Russell King <rmk+lkml@arm.linux.org.uk>
Date: Sat, 30 Dec 2006 22:46:04 +0000
> iirc, flush_anon_page() was introduced to fix non-working fuse on parisc,
> which occurs because fuse wants to use get_user_pages() to read data from
> the current processes memory space.
>
> get_user_pages() contains a call to flush_dcache_page(), whose behaviour
> is defined for shared mappings. Anonymous pages are unspecified. It
> appears that flush_anon_page() was introduced to correct this oversight.
Sparc64 flushes anonymous pages too when flush_dcache_page() is
called on such pages. It only tries to "defer" flushes for
pages which have a non-NULL page_mapping(). For NULL page_mapping()
we just flush immediately.
This works on sparc64, as sort of hinted by Linus, because we can
flush by physical page on sparc64. I guess the lack of ability to
do that is why PARISC and ARM don't do that too.
For the ptrace() cases we created the copy_{to,from}_user_page()
interfaces. So that when you access data inside of pages obtained via
a get_user_pages() call, you are supposed to use those two interfaces
so that everything works out right.
Therefore, FUSE probably could have been fixed by judicious use
of copy_{to,from}_user_page() calls instead of adding this new
ad-hoc flush_anon_page() thing.
next prev parent reply other threads:[~2006-12-31 5:23 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 15:26 fuse, get_user_pages, flush_anon_page, aliasing caches and all that again Russell King
2006-12-21 15:53 ` Miklos Szeredi
2006-12-21 16:57 ` Russell King
2006-12-21 17:51 ` Miklos Szeredi
2006-12-21 21:04 ` Jan Engelhardt
2006-12-21 21:30 ` Miklos Szeredi
2007-01-01 15:04 ` James Bottomley
2006-12-21 17:17 ` Russell King
2006-12-21 17:55 ` Miklos Szeredi
2006-12-21 18:11 ` Russell King
2006-12-21 18:30 ` Miklos Szeredi
2006-12-21 18:55 ` Russell King
2006-12-21 19:05 ` Miklos Szeredi
2006-12-21 23:51 ` Randolph Chung
2006-12-22 8:43 ` Russell King
2006-12-22 14:45 ` Randolph Chung
2006-12-30 16:39 ` Russell King
2006-12-30 16:50 ` Russell King
2006-12-30 18:26 ` Linus Torvalds
2006-12-30 22:46 ` Russell King
2006-12-31 5:23 ` David Miller [this message]
2006-12-31 9:10 ` Miklos Szeredi
2006-12-31 9:45 ` David Miller
2006-12-31 9:23 ` Russell King
2006-12-31 9:27 ` Arjan van de Ven
2006-12-31 9:47 ` David Miller
2006-12-31 10:00 ` Russell King
2006-12-31 10:04 ` David Miller
2006-12-31 12:24 ` Miklos Szeredi
2006-12-31 17:37 ` Russell King
2007-01-01 22:15 ` Miklos Szeredi
2007-01-01 23:45 ` Russell King
2007-01-02 19:40 ` Dan Williams
2007-01-02 22:53 ` James Bottomley
2007-01-02 23:19 ` David Miller
2007-01-02 23:34 ` James Bottomley
2007-01-03 0:20 ` David Miller
2007-01-03 14:16 ` Russell King
2007-01-03 15:00 ` James Bottomley
2007-01-03 15:09 ` Russell King
2007-01-07 16:09 ` James Bottomley
2007-01-07 16:30 ` Russell King
2006-12-31 20:40 ` David Miller
2006-12-31 20:58 ` Linus Torvalds
2006-12-31 21:12 ` David Miller
2007-01-01 16:44 ` James Bottomley
2007-01-01 23:04 ` David Miller
2007-01-01 23:23 ` James Bottomley
[not found] ` <1167669252.5302.57.camel@mulgrave.il.steeleye.com>
2007-01-01 23:01 ` David Miller
2007-01-01 23:17 ` Russell King
2006-12-31 9:55 ` Russell King
2006-12-31 9:46 ` David Miller
2007-01-01 14:35 ` James Bottomley
2007-01-01 16:21 ` Russell King
2006-12-30 18:21 ` Linus Torvalds
2006-12-21 16:29 ` Arjan van de Ven
2006-12-21 17:35 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061230.212338.92583434.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox