From: Dave Jones <davej@redhat.com>
To: Tilman Schmidt <tilman@imap.cc>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Sparse 0.2 warnings from {asm,net}/checksum.h
Date: Mon, 1 Jan 2007 14:10:15 -0500 [thread overview]
Message-ID: <20070101191015.GB20443@redhat.com> (raw)
In-Reply-To: <45991971.90605@imap.cc>
On Mon, Jan 01, 2007 at 03:23:45PM +0100, Tilman Schmidt wrote:
> With sparse 0.2, my previously sparse-clean driver generates the
> following warnings:
>
> include/asm/checksum.h:182:6: warning: symbol 'sum' shadows an earlier one
> include/asm/checksum.h:178:28: originally declared here
> include/net/checksum.h:33:6: warning: symbol 'sum' shadows an earlier one
> include/net/checksum.h:31:27: originally declared here
>
> Architecture is i386. The lines referred to are in the functions
> csum_and_copy_to_user() and csum_and_copy_from_user(), but I
> don't see why sparse would emit such a warning for that code.
It's complaining about the 'sum' declaration in __range_not_ok
used by access_ok(), which shadows the variable declared in
the prototype of the functions you mention.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-01-01 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 14:23 Sparse 0.2 warnings from {asm,net}/checksum.h Tilman Schmidt
2007-01-01 19:10 ` Dave Jones [this message]
2007-01-03 2:24 ` [PATCH] fix sparse " Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101191015.GB20443@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox