Re: [PATCH] OHCI: disallow autostop when wakeup is not available

Re: [PATCH] OHCI: disallow autostop when wakeup is not available

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 15 November 2006 00:28, Alan Stern wrote:
> This patch (as822) prevents the OHCI autostop mechanism from kicking in
> if the root hub is not able or not allowed to issue wakeup requests.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> Greg:
>
> This patch should go into 2.6.19-rc ASAP.  It does solve a real problem.
> The larger-scale changes Dave and I have been discussing will be submitted
> separately, for inclusion in 2.6.20.
>

Is the original problem (OHCI constantly attempting and failing to suspend 
root hub) supposed to be fixed in 2.6.20? Currently in rc3 I have

ohci_hcd 0000:00:02.0: new USB bus registered, assigned bus number 1
ohci_hcd 0000:00:02.0: created debug files
ohci_hcd 0000:00:02.0: irq 11, io mem 0xf7eff000
ohci_hcd 0000:00:02.0: resetting from state 'reset', control = 0x0
ohci_hcd 0000:00:02.0: enabling initreset quirk
ohci_hcd 0000:00:02.0: OHCI controller state
ohci_hcd 0000:00:02.0: OHCI 1.0, NO legacy support registers
ohci_hcd 0000:00:02.0: control 0x083 HCFS=operational CBSR=3
ohci_hcd 0000:00:02.0: cmdstatus 0x00000 SOC=0
ohci_hcd 0000:00:02.0: intrstatus 0x00000044 RHSC SF
ohci_hcd 0000:00:02.0: intrenable 0x8000000a MIE RD WDH
ohci_hcd 0000:00:02.0: hcca frame #0003
ohci_hcd 0000:00:02.0: roothub.a 01000203 POTPGT=1 NPS NDP=3(3)
ohci_hcd 0000:00:02.0: roothub.b 00000000 PPCM=0000 DR=0000
ohci_hcd 0000:00:02.0: roothub.status 00008000 DRWE
ohci_hcd 0000:00:02.0: roothub.portstatus [0] 0x00000100 PPS
ohci_hcd 0000:00:02.0: roothub.portstatus [1] 0x00000100 PPS
ohci_hcd 0000:00:02.0: roothub.portstatus [2] 0x00000100 PPS
usb usb1: default language 0x0409
usb usb1: new device strings: Mfr=3, Product=2, SerialNumber=1
usb usb1: Product: OHCI Host Controller
usb usb1: Manufacturer: Linux 2.6.20-rc3-1avb ohci_hcd
usb usb1: SerialNumber: 0000:00:02.0
usb usb1: uevent
usb usb1: usb_probe_device
usb usb1: configuration #1 chosen from 1 choice
usb usb1: adding 1-0:1.0 (config #1, interface 0)
usb 1-0:1.0: uevent
hub 1-0:1.0: usb_probe_interface
hub 1-0:1.0: usb_probe_interface - got id
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 3 ports detected
hub 1-0:1.0: standalone hub
hub 1-0:1.0: no power switching (usb 1.0)
hub 1-0:1.0: global over-current protection
hub 1-0:1.0: power on to power good time: 2ms
hub 1-0:1.0: local power source is good
hub 1-0:1.0: no over-current condition exists
hub 1-0:1.0: trying to enable port power on non-switchable hub
hub 1-0:1.0: state 7 ports 3 chg 0000 evt 0000
/home/bor/src/linux-git/drivers/usb/core/inode.c: creating file '001'
ohci_hcd 0000:00:02.0: auto-stop root hub
ohci_hcd 0000:00:02.0: auto-wakeup root hub
ohci_hcd 0000:00:02.0: auto-stop root hub
ohci_hcd 0000:00:02.0: auto-wakeup root hub
...

and it goes on and on until I stop it manually by usual method:

usb usb1: remote wakeup needed for autosuspend

Welcome to new year :)

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFmT/oR6LMutpd94wRAtqLAJ4yNCupGqAC8G6hkAxvuXrW7Jr7KQCgrgyE
ZZ5Sd4qeeVy+NiGHjNZ6yR8=
=Gwng
-----END PGP SIGNATURE-----

Re: [PATCH] OHCI: disallow autostop when wakeup is not available

[Alan Stern]

On Mon, 1 Jan 2007, Andrey Borzenkov wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Wednesday 15 November 2006 00:28, Alan Stern wrote:
> > This patch (as822) prevents the OHCI autostop mechanism from kicking in
> > if the root hub is not able or not allowed to issue wakeup requests.
> >
> > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> >
> > ---
> >
> > Greg:
> >
> > This patch should go into 2.6.19-rc ASAP.  It does solve a real problem.
> > The larger-scale changes Dave and I have been discussing will be submitted
> > separately, for inclusion in 2.6.20.
> >
> 
> Is the original problem (OHCI constantly attempting and failing to suspend 
> root hub) supposed to be fixed in 2.6.20?

No.  It can't be fixed in the kernel because it is a hardware bug.

>  Currently in rc3 I have
...
> ohci_hcd 0000:00:02.0: auto-stop root hub
> ohci_hcd 0000:00:02.0: auto-wakeup root hub
> ohci_hcd 0000:00:02.0: auto-stop root hub
> ohci_hcd 0000:00:02.0: auto-wakeup root hub
> ...
> 
> and it goes on and on until I stop it manually by usual method:
> 
> usb usb1: remote wakeup needed for autosuspend

The patch mentioned above allows the manual method to work.  Without the 
patch you would not be able to stop these messages at all, as you already 
have seen.

Alan Stern

Re: [linux-usb-devel] [PATCH] OHCI: disallow autostop when wakeup is not available

[David Brownell]

On Tuesday 02 January 2007 7:16 am, Alan Stern wrote:
> On Mon, 1 Jan 2007, Andrey Borzenkov wrote:

> > Is the original problem (OHCI constantly attempting and failing to suspend 
> > root hub) supposed to be fixed in 2.6.20?
> 
> No.  It can't be fixed in the kernel because it is a hardware bug.

I'm curious though:  did older kernels, say 2.6.18, have such issues?
If not, it may still be a software issue ... if you had to use the
sysfs based workaround before, I'm happy to call it a hardware issue.


> >  Currently in rc3 I have
> ...
> > ohci_hcd 0000:00:02.0: auto-stop root hub
> > ohci_hcd 0000:00:02.0: auto-wakeup root hub
> > ohci_hcd 0000:00:02.0: auto-stop root hub
> > ohci_hcd 0000:00:02.0: auto-wakeup root hub
> > ...
> > 
> > and it goes on and on until I stop it manually by usual method:
> > 
> > usb usb1: remote wakeup needed for autosuspend
> 
> The patch mentioned above allows the manual method to work. 

Not just that ... it also fixed the problem where quirk entries
saying "don't even try using remote wakeup" stopped working.

Once some pending PPC-related OHCI patches merge (support for
PS3 and other CELL systems), there will be infrastructure that
makes it easier to add quirk entries that say "this board can't
do remote wakeup properly".  At that point, we can start to
collect quirks for boards like this one.

- Dave

Re: [linux-usb-devel] [PATCH] OHCI: disallow autostop when wakeup is not available

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 04 January 2007 00:50, David Brownell wrote:
> On Tuesday 02 January 2007 7:16 am, Alan Stern wrote:
> > On Mon, 1 Jan 2007, Andrey Borzenkov wrote:
> > > Is the original problem (OHCI constantly attempting and failing to
> > > suspend root hub) supposed to be fixed in 2.6.20?
> >
> > No.  It can't be fixed in the kernel because it is a hardware bug.
>
> I'm curious though:  did older kernels, say 2.6.18, have such issues?

Yes. It is hardware problem all right.

[...]
>
> Not just that ... it also fixed the problem where quirk entries
> saying "don't even try using remote wakeup" stopped working.
>

Exactly. I am sorry for being unclear - actually the question was, whether 
quirks are implemented in 2.6.20 (because I remember them being mentioned 
before).

> Once some pending PPC-related OHCI patches merge (support for
> PS3 and other CELL systems), there will be infrastructure that
> makes it easier to add quirk entries that say "this board can't
> do remote wakeup properly".  At that point, we can start to
> collect quirks for boards like this one.
>

OK so this answers the question - it is not yet being implemented.

thank you

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFnMQ1R6LMutpd94wRAqayAKDQrqfpERc4F5LjqWMQgI6oxqqOmACdH++H
r6aDgoAQDw2SHRq+2yLaoyw=
=95Oh
-----END PGP SIGNATURE-----