Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

Alan
2007-01-02T21:17:58Z

> > This is a silly complaint because the SFF layer in libata doesn't handle
> > this case yet anyway.
>
> Yes, it's "silly" people people use configurations you find inconvenient.
>
> At least one embedded x86 case cares, that I know of. They only needed
> to make two minor changes to make it work.

*It is not part of 2.6.20*

> The code no long reserves resources for the "extra" PCI BAR that often
> exists on PCI controllers regardless of legacy/native mode. Previously,
> the code called pci_request_regions() to reserve ALL regions attached to
> the PCI device.

We use BAR5 on two devices in legacy mode. Both of those reserve all the
other resources. We can fix BAR5 in .21 when all the combined mode crap
goes away.

> You have suddenly decided that it's OK to --not reserve at all-- these
> additional regions.

It's not ideal - but it is perfectly sufficient for 2.6.20

> Proof: The AHCI PCI BAR (#5, zero-based) is clearly NOT reserved, even
> though we talk to it, in piix_disable_ahci() of ata_piix.c.

We always claim the other BARs so catch a collision.

Alan