From: Jens Axboe <jens.axboe@oracle.com>
To: yc_zhou <yc_zhou@ncic.ac.cn>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] Adding branch to remove possible unnecessary inst
Date: Tue, 2 Jan 2007 09:32:56 +0100 [thread overview]
Message-ID: <20070102083255.GP2483@kernel.dk> (raw)
In-Reply-To: <459752B6.1020904@ncic.ac.cn>
On Sun, Dec 31 2006, yc_zhou wrote:
> Function blk_queue_bounce_limit using dma flag to determine whether
> assigned a certain value for member of request_queue_t. But the
> assignment is unconditionally after the flag is set. It introduce
> possible unnecessary instructions.
Your patch is white space damaged, it makes it hard to read and
impossible to apply.
Note that blk_queue_bounce_limit() is an initialization function, so not
much gained from optimizing on that.
--
Jens Axboe
prev parent reply other threads:[~2007-01-02 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 6:03 [PATCH 2.6.19] Adding branch to remove possible unnecessary inst yc_zhou
2007-01-02 8:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102083255.GP2483@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yc_zhou@ncic.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox