From: David Miller <davem@davemloft.net>
To: amit2030@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0.
Date: Wed, 03 Jan 2007 18:47:20 -0800 (PST) [thread overview]
Message-ID: <20070103.184720.122834327.davem@davemloft.net> (raw)
In-Reply-To: <20061230182603.d3815dcb.amit2030@gmail.com>
From: Amit Choudhary <amit2030@gmail.com>
Date: Sat, 30 Dec 2006 18:26:03 -0800
> Description: Fix infinite recursion when alignment passed is 0 in function aligned_kmalloc(), in file drivers/atm/firestream.c. Also, a negative value for alignment does not make sense. Check for negative value too.
> The function prototype is:
> static void __devinit *aligned_kmalloc (int size, gfp_t flags, int alignment).
>
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
There is only one call to aligned_kmalloc() and it passes in
0x10 as the alignment argument. Therefore all of this checking
is completely pointless.
prev parent reply other threads:[~2007-01-04 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 2:26 [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0 Amit Choudhary
2006-12-31 5:59 ` Mitchell Blank Jr
2007-01-04 7:29 ` Pekka Enberg
2007-01-04 2:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070103.184720.122834327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox