Re: [PATCH] 4/4 block: explicit plugging

[Jens Axboe <jens.axboe@oracle.com>]

On Wed, Jan 03 2007, Andrew Morton wrote:
> On Wed,  3 Jan 2007 08:48:28 +0100
> Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > This is a patch to perform block device plugging explicitly in the submitting
> > process context rather than implicitly by the block device.
> 
> I don't think anyone will regret the passing of
> address_space_operations.sync_page().

Hardly :-)

> Do you have any benchmarks which got faster with these changes?

On the hardware I have immediately available, I see no regressions wrt
performance. With instrumentation it's simple to demonstrate that most
of the queueing activity of an io heavy benchmark spends less time in
the kernel (most merging activity takes place outside of the queue lock,
hence queueing is lock free).

I've asked Ken to run this series on some of his big iron, I hope he'll
have some results for us soonish. I can run some pseudo benchmarks on a
4-way here with some simulated storage to demonstrate the locking
improvements.

I don't see 3/4 and 4/4 on lkml yet, I wonder if they got lost.

-- 
Jens Axboe