* [PATCH 4/4] i386: Specify section flags while creating new sections
@ 2007-01-03 11:34 Vivek Goyal
0 siblings, 0 replies; only message in thread
From: Vivek Goyal @ 2007-01-03 11:34 UTC (permalink / raw)
To: linux kernel mailing list
Cc: Fastboot mailing list, Morton Andrew Morton, Andi Kleen,
Eric W. Biederman, Sam Ravnborg
o Older binutils (older than 2.6.15) require explicit flags to be set
for section. (if a section has been defined using "section" directive).
Otherwise a section which should have been allocatable and executable
(AX) will not have properties as per intention.
o I had put a patch in -mm which will break the things if used with
older binutils. Hence this is the fix on top of that patch.
http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc2/2.6.20-rc2-mm1/broken-out/i386-move-startup_32-in-texthead-section.patch
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
arch/i386/kernel/head.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN arch/i386/kernel/head.S~i386-modify-section-directive-for-older-binutils arch/i386/kernel/head.S
--- linux-2.6.20-rc2-mm1-reloc/arch/i386/kernel/head.S~i386-modify-section-directive-for-older-binutils 2007-01-03 11:58:51.000000000 +0530
+++ linux-2.6.20-rc2-mm1-reloc-root/arch/i386/kernel/head.S 2007-01-03 12:00:03.000000000 +0530
@@ -53,7 +53,7 @@
* any particular GDT layout, because we load our own as soon as we
* can.
*/
-.section .text.head
+.section .text.head,"ax",@progbits
ENTRY(startup_32)
#ifdef CONFIG_PARAVIRT
@@ -155,9 +155,9 @@ page_pde_offset = (__PAGE_OFFSET >> 20);
*/
#ifdef CONFIG_HOTPLUG_CPU
-.section .text
+.section .text,"ax",@progbits
#else
-.section .init.text
+.section .init.text,"ax",@progbits
#endif
#ifdef CONFIG_SMP
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-01-03 11:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-03 11:34 [PATCH 4/4] i386: Specify section flags while creating new sections Vivek Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox