From: "Malte Schröder" <MalteSch@gmx.de>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
berni@birkenwald.de, netfilter-devel@lists.netfilter.org
Subject: Re: [BUG] panic 2.6.20-rc3 in nf_conntrack
Date: Wed, 3 Jan 2007 20:18:47 +0100 [thread overview]
Message-ID: <200701032018.51184.MalteSch@gmx.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0701030913470.8163@tux.rsn.bth.se>
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
On Wednesday 03 January 2007 09:34, Martin Josefsson wrote:
> I saw your (correct) analysis after having made the patch below, it has
> been tested successfully by Bernhard Schmidt. (Netfilter bugzilla #528)
>
> Check the return value of nfct_nat() in device_cmp(), we might very well
> have non NAT conntrack entries as well.
>
I was not capable to reproduce the problem. Thanks :)
> Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se>
>
> --- linux-2.6.20-rc3/net/ipv4/netfilter/ipt_MASQUERADE.c.orig 2007-01-02
> 22:47:14.000000000 +0100 +++
> linux-2.6.20-rc3/net/ipv4/netfilter/ipt_MASQUERADE.c 2007-01-02
> 22:57:11.000000000 +0100 @@ -127,10 +127,13 @@
> static inline int
> device_cmp(struct ip_conntrack *i, void *ifindex)
> {
> + int ret;
> #ifdef CONFIG_NF_NAT_NEEDED
> struct nf_conn_nat *nat = nfct_nat(i);
> +
> + if (!nat)
> + return 0;
> #endif
> - int ret;
>
> read_lock_bh(&masq_lock);
> #ifdef CONFIG_NF_NAT_NEEDED
--
---------------------------------------
Malte Schröder
MalteSch@gmx.de
ICQ# 68121508
---------------------------------------
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-01-03 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 7:25 [BUG] panic 2.6.20-rc3 in nf_conntrack Chuck Ebbert
2007-01-03 8:34 ` Martin Josefsson
2007-01-03 19:18 ` Malte Schröder [this message]
2007-01-03 20:44 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2007-01-01 16:53 Malte Schröder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701032018.51184.MalteSch@gmx.de \
--to=maltesch@gmx.de \
--cc=76306.1226@compuserve.com \
--cc=berni@birkenwald.de \
--cc=gandalf@wlug.westbo.se \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox