From: Robert Fitzsimons <robfitz@273k.net>
To: Michael Krufky <mkrufky@linuxtv.org>, "J.H." <warthog19@eaglescrag.net>
Cc: git@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
Michael Krufky <mkrufky@gmail.com>
Subject: [PATCH] gitweb: Fix shortlog only showing HEAD revision.
Date: Wed, 3 Jan 2007 20:25:55 +0000 [thread overview]
Message-ID: <20070103202555.GA25768@localhost> (raw)
In-Reply-To: <459C0232.3090804@linuxtv.org>
My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug
found by Michael Krufky which caused the passed in hash value to be
ignored, so shortlog would only show the HEAD revision.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
Thanks for finding this Michael. It' just a small bug introducted by a
recent change I made. Including John 'Warthog9' so hopefully he can add
this to the version of gitweb which is hosted on kernel.org.
Robert
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index d845e91..2e94c2c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4423,7 +4423,7 @@ sub git_shortlog {
}
my $refs = git_get_references();
- my @commitlist = parse_commits($head, 101, (100 * $page));
+ my @commitlist = parse_commits($hash, 101, (100 * $page));
my $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));
my $next_link = '';
--
t1.gaaaa
next prev parent reply other threads:[~2007-01-03 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 19:21 GITWEB branch shortlog broken after recent update on kernel.org Michael Krufky
2007-01-03 20:25 ` Robert Fitzsimons [this message]
2007-01-03 20:36 ` [PATCH] gitweb: Fix shortlog only showing HEAD revision Jakub Narebski
2007-01-05 21:21 ` Michael Krufky
2007-01-05 21:25 ` J.H.
2007-01-03 20:30 ` [PATCH] gitweb: Make shortlog use 'h' (head) parameter again Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070103202555.GA25768@localhost \
--to=robfitz@273k.net \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@gmail.com \
--cc=mkrufky@linuxtv.org \
--cc=warthog19@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox