From: Craig Schlenter <craig@codefountain.com>
To: Komuro <komurojun-mbn@nifty.com>
Cc: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>,
bunk@stusta.de, jgarzik@pobox.com, viro@ftp.linux.org.uk,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer
Date: Thu, 4 Jan 2007 14:23:30 +0200 [thread overview]
Message-ID: <20070104122330.GA2233@craigdell.detnet.com> (raw)
In-Reply-To: <20070105054546.953196e5.komurojun-mbn@nifty.com>
On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote:
> Hi,
>
> I made a patch below.
> With this patch, the ftp-transfer-stop problem does not happen.
> Therefore, I think this is not a problem of vsftpd.
>
> Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED
> to iov_len?
>
>
>
> --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900
> +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900
> @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t
> TCPOLEN_TIMESTAMP);
> rep.opt[1] = htonl(tcp_time_stamp);
> rep.opt[2] = htonl(ts);
> - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED;
> + arg.iov[0].iov_len = sizeof(rep);
Perhaps this was supposed to be
arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED;
That's what the ipv6 stuff does in places.
bye,
--Craig
next prev parent reply other threads:[~2007-01-04 12:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 12:27 [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer Komuro
2006-12-17 4:02 ` Al Viro
2006-12-17 14:23 ` Komuro
2006-12-18 3:01 ` Adrian Bunk
2006-12-18 20:55 ` Komuro
2006-12-23 11:17 ` Komuro
2006-12-30 9:50 ` Komuro
2006-12-30 1:23 ` YOSHIFUJI Hideaki / 吉藤英明
2006-12-30 11:59 ` Komuro
2006-12-30 14:19 ` YOSHIFUJI Hideaki / 吉藤英明
2006-12-31 9:42 ` Komuro
2007-01-01 17:18 ` Komuro
2007-01-04 20:45 ` Komuro
2007-01-04 12:23 ` Craig Schlenter [this message]
2007-01-09 1:24 ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-09 5:11 ` [PATCH] " Craig Schlenter
2007-01-09 5:22 ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-09 8:11 ` David Miller
2007-01-09 22:01 ` Komuro
[not found] ` <20070211101537.e40fa309.komurojun-mbn@nifty.com>
2007-02-11 1:56 ` [BUG] PATA_PCMCIA does not work Alan
2007-02-11 10:32 ` Haavard Skinnemoen
2007-02-11 2:40 ` Komuro
2007-02-18 2:09 ` Komuro
2007-02-21 15:37 ` Alan
2007-02-21 15:24 ` Manuel Lauss
2007-02-24 2:06 ` Komuro
2007-02-24 23:14 ` Komuro
2007-02-25 1:45 ` Jeff Garzik
2007-02-25 2:43 ` Komuro
2007-03-21 1:56 ` [PATCH]: pcmcia - spot slave decode flaws (for testing) Komuro
2007-03-17 13:00 ` [BUG] PATA_PCMCIA cmd port Komuro
2007-03-17 15:43 ` libata reports bogus addresses for everything (was PATA_PCMCIA cmd port) Alan Cox
2007-03-18 5:48 ` Tejun Heo
2007-03-17 16:10 ` [BUG] PATA_PCMCIA cmd port Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070104122330.GA2233@craigdell.detnet.com \
--to=craig@codefountain.com \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=komurojun-mbn@nifty.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox