From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Marcin Juszkiewicz <openembedded@hrw.one.pl>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] backlight control for Frontpath ProGear HX1050+
Date: Fri, 5 Jan 2007 08:23:51 +0000 [thread overview]
Message-ID: <20070105082351.GA32582@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200701050903.31859.openembedded@hrw.one.pl>
On Fri, Jan 05, 2007 at 09:03:30AM +0100, Marcin Juszkiewicz wrote:
> Index: linux-2.6.18/drivers/video/backlight/progear_bl.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.18/drivers/video/backlight/progear_bl.c 2007-01-05 08:48:41.000000000 +0100
> +static int progearbl_probe(struct platform_device *pdev)
> +{
> + u8 temp;
> +
> + pmu_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M7101, 0);
> + if(!pmu_dev) {
> + printk("ALI M7101 PMU not found.\n");
> + return(-1);
There are enumerated constants for these return values. Please use the
proper and appropriate constants.
> + }
> +
> + sb_dev = pci_find_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, 0);
> + if(!sb_dev) {
> + printk("ALI 1533 SB not found.\n");
> + return(-1);
Ditto.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-01-05 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 8:03 [PATCH] backlight control for Frontpath ProGear HX1050+ Marcin Juszkiewicz
2007-01-05 8:23 ` Russell King [this message]
2007-01-05 9:55 ` Marcin Juszkiewicz
2007-01-05 9:39 ` Alan
2007-01-05 11:15 ` Marcin Juszkiewicz
2007-01-05 14:03 ` Mariusz Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2007-02-06 13:30 Marcin Juszkiewicz
2007-02-06 19:26 ` Richard Purdie
2007-02-07 8:02 ` Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070105082351.GA32582@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=openembedded@hrw.one.pl \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox