From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Zachary Amsden <zach@vmware.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Chris Wright <chrisw@sous-sol.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Adrian Bunk <bunk@stusta.de>,
airlied@linux.ie
Subject: Re: [patch] paravirt: isolate module ops
Date: Sun, 7 Jan 2007 19:43:29 +0100 [thread overview]
Message-ID: <20070107184329.GA30270@elte.hu> (raw)
In-Reply-To: <20070107183946.GB8158@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Sat, Jan 06, 2007 at 07:31:52PM +0000, Christoph Hellwig wrote:
> > On Sun, Jan 07, 2007 at 03:18:45AM +1100, Rusty Russell wrote:
> > > PS. drm_memory.h has a "drm_follow_page": this forces us to uninline
> > > various page tables ops. Can this use follow_page() somehow, or do we
> > > need an "__follow_page" export for this case?
> >
> > Not if avoidable. And it seems avoidable as drm really should be using
> > vmalloc_to_page. Untested patch below:
>
> Even better we can actualy avid most of the page table walks
> completely.
agreed. I think there's an important side-observation here as well:
having inlined functions uninlined and exported puts them under a lot
more scrutiny. Hence individual exports instead of the global
paravirt_ops export is a big plus.
Ingo
next prev parent reply other threads:[~2007-01-07 18:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 0:07 [patch] paravirt: isolate module ops Ingo Molnar
2007-01-06 0:31 ` Zachary Amsden
2007-01-06 6:25 ` Rusty Russell
2007-01-06 7:08 ` Ingo Molnar
2007-01-06 7:12 ` Ingo Molnar
2007-01-06 17:42 ` Rusty Russell
2007-01-06 18:32 ` Ingo Molnar
2007-01-06 20:55 ` Zachary Amsden
2007-01-07 1:09 ` Rusty Russell
2007-01-07 14:07 ` Zachary Amsden
2007-01-06 7:14 ` Ingo Molnar
2007-01-06 9:50 ` Zachary Amsden
2007-01-06 10:52 ` Arjan van de Ven
2007-01-06 16:18 ` Rusty Russell
2007-01-06 19:31 ` Christoph Hellwig
2007-01-07 5:35 ` Rusty Russell
2007-01-07 18:39 ` Christoph Hellwig
2007-01-07 18:43 ` Ingo Molnar [this message]
2007-01-08 0:54 ` Dave Airlie
2007-01-06 1:02 ` Zachary Amsden
2007-01-06 2:07 ` Arjan van de Ven
2007-01-06 4:41 ` Zachary Amsden
2007-01-06 5:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070107184329.GA30270@elte.hu \
--to=mingo@elte.hu \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=chrisw@sous-sol.org \
--cc=hch@infradead.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox