Re: [PATCH] Driver core: fix refcounting bug

Greg KH
2007-01-17T00:46:33Z

On Mon, Jan 08, 2007 at 11:06:44AM -0500, Alan Stern wrote:
> This patch (as832) fixes a newly-introduced bug in the driver core.
> When a kobject is assigned to a kset, it must acquire a reference to
> the kset.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> The bug was introduced in Kay's "unify /sys/class and /sys/bus at
> /sys/subsystem" patch.
>
> I left the assignment of class_dev->kobj.parent as it was, although it is
> not needed. The following call to kobject_add() will end up doing the
> same thing.
>
> Alan Stern
>
> P.S.: Tracking down refcounting bugs is a real pain! I spent an entire
> afternoon on this one... :-(

Thanks, I've merged your patch with the one from Kay so we don't
introduce a bug along the way.

greg k-h