From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: Adrian Bunk <bunk@stusta.de>,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
"Steven M. Christey" <coley@mitre.org>
Subject: Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
Date: Tue, 9 Jan 2007 14:52:47 -0800 [thread overview]
Message-ID: <20070109145247.1ffc0cd3.akpm@osdl.org> (raw)
In-Reply-To: <200701092343.01112.ak@suse.de>
On Tue, 9 Jan 2007 23:43:00 +0100
Andi Kleen <ak@suse.de> wrote:
>
> >
> > But the patch is a bugfix. Without it, you cannot do
> >
> > RESTORE_CONTEXT \
> > .globl ... \
> >
> > Was the addition of this restriction to RESTORE_CONTEXT deliberate, or
> > mistaken?
>
> RESTORE_CONTEXT is a private macro and I don't see why we should
> support out of tree usages for that. As long as it works as it is
> in the tree it is fine.
>
In other words we'll leave it in its present buggy form so that it will
explode next time someone tries to use it for something new, rather than a)
fixing that potential problem and b) fixing a real problem with a popular
external GPLed product.
Unfathomable.
next prev parent reply other threads:[~2007-01-09 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 2:55 [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT Adrian Bunk
2007-01-09 11:01 ` Andi Kleen
2007-01-09 22:04 ` Andrew Morton
2007-01-09 22:43 ` Andi Kleen
2007-01-09 22:52 ` Andrew Morton [this message]
2007-01-09 23:43 ` Andi Kleen
2007-01-10 8:37 ` [discuss] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070109145247.1ffc0cd3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=bunk@stusta.de \
--cc=coley@mitre.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox