From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
"Steven M. Christey" <coley@mitre.org>
Subject: Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
Date: Wed, 10 Jan 2007 00:43:48 +0100 [thread overview]
Message-ID: <200701100043.49092.ak@suse.de> (raw)
In-Reply-To: <20070109145247.1ffc0cd3.akpm@osdl.org>
>
> In other words we'll leave it in its present buggy form so that it will
> explode next time someone tries to use it for something new, rather than a)
It shouldn't be used for anything new. It's really a private macro
in the context switch code, nothing that any other code is supposed
to use.
> fixing that potential problem and b) fixing a real problem with a popular
> external GPLed product.
kgdb shouldn't need any patches to core kernel I had it some time ago running fine
just by hooking it into the die hooks (and minor changes to the serial layer,
with netpoll these shouldn't be even needed anymore)
If the kgdb people need more changes they should submit them.
But I suspect if they change RESTORE_CONTEXT they're doing something wrong
anyways and they just need to fix their code properly.
-Andi
next prev parent reply other threads:[~2007-01-09 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 2:55 [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT Adrian Bunk
2007-01-09 11:01 ` Andi Kleen
2007-01-09 22:04 ` Andrew Morton
2007-01-09 22:43 ` Andi Kleen
2007-01-09 22:52 ` Andrew Morton
2007-01-09 23:43 ` Andi Kleen [this message]
2007-01-10 8:37 ` [discuss] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701100043.49092.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=coley@mitre.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox