public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kbuild: Don't ignore localversion files if the path includes a ~
@ 2007-01-10 11:24 Bastian Blank
  0 siblings, 0 replies; only message in thread
From: Bastian Blank @ 2007-01-10 11:24 UTC (permalink / raw)
  To: kai, sam; +Cc: linux-kernel, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Hi Kai, Sam

The following patch fixes the problem that localversion files where
ignored if the tree lives in a path which contains a ~. It changes the
test to apply to the filename only.

Debian allows versions which contains ~ in it. The upstream part of the
version is in the directory name of the build tree and we got weird
results because the localversion files was just got ignored in this
case.

--- a/Makefile
+++ b/Makefile
@@ -807,7 +807,7 @@ space      := $(nullstring) # end of line
 ___localver = $(objtree)/localversion* $(srctree)/localversion*
 __localver  = $(sort $(wildcard $(___localver)))
 # skip backup files (containing '~')
-_localver = $(foreach f, $(__localver), $(if $(findstring ~, $(f)),,$(f)))
+_localver = $(foreach f, $(__localver), $(if $(findstring ~, $(notdir $(f))),,$(f)))
 
 localver = $(subst $(space),, \
           $(shell cat /dev/null $(_localver)) \

-- 
Totally illogical, there was no chance.
		-- Spock, "The Galileo Seven", stardate 2822.3

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-10 11:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-10 11:24 [PATCH] kbuild: Don't ignore localversion files if the path includes a ~ Bastian Blank

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox