From: Bernhard Schiffner <bernhard@schiffner-limbach.de>
To: linux-kernel@vger.kernel.org
Cc: Roman Zippel <zippel@linux-m68k.org>
Subject: Re: ntp.c : possible inconsistency?
Date: Wed, 10 Jan 2007 16:29:44 +0100 [thread overview]
Message-ID: <200701101629.44528.bernhard@schiffner-limbach.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0701101516420.14458@scrub.home>
> Without a further explanation of this craziness, it's a little hard to
> discuss...
Let's try it:
time_constant is created for internal use of ntp.c and added by 4
- time_constant = min(txc->constant + 4, (long)MAXTC);
+ time_constant = min(txc->constant + 4, (long)MAXTC + 4);
But sometimes it is written back to data referenced from outside. So let's do
the + 4 backwards ...
- txc->constant = time_constant;
+ txc->constant = time_constant - 4;
otherwise I'd like to speak of an inconsistency. It doesn't depend of actual
use and other topics.
Bernhard
next prev parent reply other threads:[~2007-01-10 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 13:23 ntp.c : possible inconsistency? Bernhard Schiffner
2007-01-10 14:30 ` Roman Zippel
2007-01-10 15:29 ` Bernhard Schiffner [this message]
2007-01-15 12:43 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701101629.44528.bernhard@schiffner-limbach.de \
--to=bernhard@schiffner-limbach.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox