From: "J.A. Magallón" <jamagallon@ono.com>
To: "linux-os \(Dick Johnson\)" <linux-os@analogic.com>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
"Stefan Richter" <stefanr@s5r6.in-berlin.de>,
"Linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: Re: macros: "do-while" versus "({ })" and a compile-time error
Date: Wed, 10 Jan 2007 22:49:22 +0100 [thread overview]
Message-ID: <20070110224922.2de6a641@werewolf-wl> (raw)
In-Reply-To: <Pine.LNX.4.61.0701100715330.16104@chaos.analogic.com>
On Wed, 10 Jan 2007 07:16:55 -0500, "linux-os \(Dick Johnson\)" <linux-os@analogic.com> wrote:
>
> On Wed, 10 Jan 2007, Robert P. J. Day wrote:
>
> > On Tue, 9 Jan 2007, linux-os (Dick Johnson) wrote:
> >
> >>
> >> On Tue, 9 Jan 2007, Stefan Richter wrote:
> >>
> >>> Robert P. J. Day wrote:
> >>>> just to stir the pot a bit regarding the discussion of the two
> >>>> different ways to define macros,
> >>>
> >>> You mean function-like macros, right?
> >>>
> >>>> i've just noticed that the "({ })"
> >>>> notation is not universally acceptable. i've seen examples where
> >>>> using that notation causes gcc to produce:
> >>>>
> >>>> error: braced-group within expression allowed only inside a function
> >>>
> >>> And function calls and macros which expand to "do { expr; } while (0)"
> >>> won't work anywhere outside of functions either.
> >>>
> >>>> i wasn't aware that there were limits on this notation. can someone
> >>>> clarify this? under what circumstances *can't* you use that notation?
> >>>> thanks.
> >>>
> >>> The limitations are certainly highly compiler-specific.
> >>
> >> I don't think so. You certainly couldn't write working 'C' code like
> >> this:
> >>
> >> do { a = 1; } while(0);
> >>
> >> This _needs_ to be inside a function. In fact any runtime operations
> >> need to be inside functions. It's only in assembly that you could
> >> 'roll your own' code like:
> >>
> >> main:
> >> ret 0
> >>
> >>
> >> Most of these errors come about as a result of changes where a macro
> >> used to define a constant. Later on, it was no longer a constant in
> >> code that didn't actually get compiled during the testing.
> >
> > just FYI, the reason i brought this up in the first place is that i
> > noticed that the ALIGN() macro in kernel.h didn't verify that the
> > alignment value was a power of 2, so i thought -- hmmm, i wonder if
> > there are any invocations where that's not true, so i (temporarily)
> > rewrote ALIGN to incorporate that check, and the build blew up
> > including include/net/neighbour.h, which contains the out-of-function
> > declaration:
> >
> > struct neighbour
> > {
> > ...
> > unsigned char ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned long))];
> > ...
> >
> > so it's not a big deal, it was just me goofing around and breaking
> > things.
> >
> > rday
>
>
> Hmmm, in that case you would be trying to put code inside a structure!
> Neat --if you could do it!
>
The ({ }) is a block expression, ie, it allows declaring variables and
executing code. Its a gcc extension trying to resemble what other languages
like ML have:
ML:
f = let
y = x*x
in
2*y + sin(y)
end
GNU C:
f = ({ int y = x*x;
2*y + sin(y); })
So you can put it on every place you could also put a { } block or declare a
variable. {} is a compund command and ({ }) is a compund expression
(or block expression, do not know which is the good name in engelish).
--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2007.1 (Cooker) for i586
Linux 2.6.19-jam03 (gcc 4.1.2 20061110 (prerelease) (4.1.2-0.20061110.1mdv2007.1)) #1 SMP PREEMPT
next prev parent reply other threads:[~2007-01-10 21:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 18:50 macros: "do-while" versus "({ })" and a compile-time error Robert P. J. Day
2007-01-09 17:08 ` H. Peter Anvin
2007-01-09 17:33 ` Stefan Richter
2007-01-09 19:23 ` linux-os (Dick Johnson)
2007-01-09 20:19 ` Stefan Richter
2007-01-10 6:20 ` Robert P. J. Day
2007-01-10 12:16 ` linux-os (Dick Johnson)
2007-01-10 13:46 ` Robert P. J. Day
2007-01-10 14:07 ` linux-os (Dick Johnson)
2007-01-10 18:25 ` Stefan Richter
2007-01-10 21:49 ` J.A. Magallón [this message]
2007-01-10 22:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070110224922.2de6a641@werewolf-wl \
--to=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=rpjday@mindspring.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox