Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

Stephen Hemminger
2006-11-20T18:06:12Z

On Mon, 20 Nov 2006 13:21:59 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> On Monday 20 November 2006 07:12, Chris Snook wrote:
> > >
> > > Any reason why you can't use generic_mii_ioctl?
> >
> > I decided to mostly leave this code alone, in the hope that we could
> > just rip out MII support entirely and nobody would mind.  What do you think?
> >
>
> Normally, I think you should just implement mdio_read/mdio_write functions
> and then use all the helpers from drivers/net/mii.c to implement mii_ioctl
> and other functions like ethtool_gset.
>
> Arnd <><
>

Using common MII code is good, but one problem with the existing MII code is that
it doesn't work when device is down. This makes it impossible to set speed/duplex
before device comes up.

--
Stephen Hemminger <shemminger@osdl.org>