From: Jamie Lenehan <lenehan@twibble.org>
To: David Brownell <david-b@pacbell.net>,
Alessandro Zummo <alessandro.zummo@towertech.it>,
Paul Mundt <lethal@linux-sh.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com
Subject: Re: [patch 2.6.20-rc3] rtc-sh correctly reports rtc_wkalrm.enabled
Date: Thu, 11 Jan 2007 22:40:35 +1100 [thread overview]
Message-ID: <20070111114034.GA6333@twibble.org> (raw)
In-Reply-To: <200701052055.06264.david-b@pacbell.net>
On Fri, Jan 05, 2007 at 08:55:05PM -0800, David Brownell wrote:
[...]
> An audit of the RTC driver treatment of the "enabled" flag turned
> up a handful of clear bugs; most drivers handle it the same now
Yeah, I missed the existing of the enabled flag when I added alarm
support to the driver. Your patch is fine.
> This driver has another issue: sh_rtc_set_alarm() ignores the
> "enabled" flag, rather than using it to tell whether the alarm
> should be enabled on exit from that routine. One at a time. :)
I'll can take care of this.
--
Jamie Lenehan <lenehan@twibble.org>
prev parent reply other threads:[~2007-01-11 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 4:55 [patch 2.6.20-rc3] rtc-sh correctly reports rtc_wkalrm.enabled David Brownell
2007-01-06 18:49 ` Paul Mundt
2007-01-11 11:40 ` Jamie Lenehan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111114034.GA6333@twibble.org \
--to=lenehan@twibble.org \
--cc=alessandro.zummo@towertech.it \
--cc=david-b@pacbell.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox