public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@gmail.com>
To: Vojtech Pavlik <vojtech@suse.cz>, Greg KH <greg@kroah.com>
Cc: linux-usb-devel@lists.sourceforge.net,
	linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org,
	Anssi Hannula <anssi.hannula@gmail.com>
Subject: [patch 1/3] hid: allow force feedback for multi-input devices
Date: Thu, 11 Jan 2007 16:51:16 +0200	[thread overview]
Message-ID: <20070111145422.080260045@delta.onse.fi> (raw)
In-Reply-To: 20070111145115.405679742@delta.onse.fi

[-- Attachment #1: input-hid-allow-multi-input-ff.diff --]
[-- Type: text/plain, Size: 1152 bytes --]

Allow hid devices with HID_QUIRK_MULTI_INPUT to have force feedback.
This was previously disabled because there were not any force
feedback drivers for such devices. This will change with my upcoming
patch.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>

---
 drivers/usb/input/hid-core.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Index: linux-2.6.20-rc3-ptr/drivers/usb/input/hid-core.c
===================================================================
--- linux-2.6.20-rc3-ptr.orig/drivers/usb/input/hid-core.c	2007-01-06 00:38:41.000000000 +0200
+++ linux-2.6.20-rc3-ptr/drivers/usb/input/hid-core.c	2007-01-07 20:53:21.000000000 +0200
@@ -1315,11 +1315,7 @@ static int hid_probe(struct usb_interfac
 		return -ENODEV;
 	}
 
-	/* This only gets called when we are a single-input (most of the
-	 * time). IOW, not a HID_QUIRK_MULTI_INPUT. The hid_ff_init() is
-	 * only useful in this case, and not for multi-input quirks. */
-	if ((hid->claimed & HID_CLAIMED_INPUT) &&
-			!(hid->quirks & HID_QUIRK_MULTI_INPUT))
+	if ((hid->claimed & HID_CLAIMED_INPUT))
 		hid_ff_init(hid);
 
 	printk(KERN_INFO);

--
Anssi Hannula

  reply	other threads:[~2007-01-11 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-11 14:51 [patch 0/3] hid: series of patches for PantherLord USB/PS2 2in1 Adapter support Anssi Hannula
2007-01-11 14:51 ` Anssi Hannula [this message]
2007-01-11 14:51 ` [patch 2/3] hid: quirk for multi-input devices with unneeded output reports Anssi Hannula
2007-01-11 14:51 ` [patch 3/3] hid: force feedback driver for PantherLord USB/PS2 2in1 Adapter Anssi Hannula
2007-01-11 16:51 ` [patch 0/3] hid: series of patches for PantherLord USB/PS2 2in1 Adapter support Greg KH
2007-01-11 18:56 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070111145422.080260045@delta.onse.fi \
    --to=anssi.hannula@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox