Re: [patch]cleanup and error reporting for sound/core/init.c

Takashi Iwai
2007-01-16T16:52:00Z

At Sat, 13 Jan 2007 07:37:59 +0100,
Oliver Neukum wrote:
>
> Am Freitag, 12. Januar 2007 18:42 schrieb Takashi Iwai:
> > At Fri, 12 Jan 2007 14:49:57 +0100,
> > Oliver Neukum wrote:
> > >
> > > + } else {
> > > + if (idx < snd_ecards_limit) {
> > > + if (snd_cards_lock & (1 << idx))
> > > + err = -EBUSY; /* invalid */
> > > + } else if (idx < SNDRV_CARDS)
> > > + snd_ecards_limit = idx + 1; /* increase the limit */
> > > + else
> > > + err = -ENODEV;
> >
> > The indent looks strange in the above three lines.
> > Also, for me it's not much better than before... :)
> > (all if's are comparisons of idx with other values.)
>
> Hi,
>
> OK, how about this one? The original indentation makes the control
> flow very hard to follow.
>
> Regards
> Oliver
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

Thanks, now applied to ALSA tree.

Takashi