public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, swhiteho@redhat.com
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: [-mm patch] make gfs2_change_nlink_i() static
Date: Sat, 13 Jan 2007 10:56:41 +0100	[thread overview]
Message-ID: <20070113095640.GK7469@stusta.de> (raw)
In-Reply-To: <20070111222627.66bb75ab.akpm@osdl.org>

On Thu, Jan 11, 2007 at 10:26:27PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.20-rc3-mm1:
>...
>  git-gfs2-nmw.patch
>...
>  git trees
>...


This patch makes the needlessly globlal gfs2_change_nlink_i() static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 fs/gfs2/inode.c |   88 ++++++++++++++++++++++++------------------------
 fs/gfs2/inode.h |    1 
 2 files changed, 44 insertions(+), 45 deletions(-)

--- linux-2.6.20-rc4-mm1/fs/gfs2/inode.h.old	2007-01-13 08:56:24.000000000 +0100
+++ linux-2.6.20-rc4-mm1/fs/gfs2/inode.h	2007-01-13 08:56:30.000000000 +0100
@@ -40,7 +40,6 @@
 
 int gfs2_dinode_dealloc(struct gfs2_inode *inode);
 int gfs2_change_nlink(struct gfs2_inode *ip, int diff);
-int gfs2_change_nlink_i(struct gfs2_inode *ip);
 struct inode *gfs2_lookupi(struct inode *dir, const struct qstr *name,
 			   int is_root, struct nameidata *nd);
 struct inode *gfs2_createi(struct gfs2_holder *ghs, const struct qstr *name,
--- linux-2.6.20-rc4-mm1/fs/gfs2/inode.c.old	2007-01-13 08:56:37.000000000 +0100
+++ linux-2.6.20-rc4-mm1/fs/gfs2/inode.c	2007-01-13 08:57:21.000000000 +0100
@@ -280,6 +280,50 @@
 	return error;
 }
 
+static int gfs2_change_nlink_i(struct gfs2_inode *ip)
+{
+	struct gfs2_sbd *sdp = ip->i_inode.i_sb->s_fs_info;
+	struct gfs2_inode *rindex = GFS2_I(sdp->sd_rindex);
+	struct gfs2_glock *ri_gl = rindex->i_gl;
+	struct gfs2_rgrpd *rgd;
+	struct gfs2_holder ri_gh, rg_gh;
+	int existing, error;
+
+	/* if we come from rename path, we could have the lock already */
+	existing = gfs2_glock_is_locked_by_me(ri_gl);
+	if (!existing) {
+		error = gfs2_rindex_hold(sdp, &ri_gh);
+		if (error)
+			goto out;
+	}
+
+	/* find the matching rgd */
+	error = -EIO;
+	rgd = gfs2_blk2rgrpd(sdp, ip->i_num.no_addr);
+	if (!rgd)
+		goto out_norgrp;
+
+	/*
+	 * Eventually we may want to move rgd(s) to a linked list
+	 * and piggyback the free logic into one of gfs2 daemons
+	 * to gain some performance.
+	 */
+	if (!rgd->rd_gl || !gfs2_glock_is_locked_by_me(rgd->rd_gl)) {
+		error = gfs2_glock_nq_init(rgd->rd_gl, LM_ST_EXCLUSIVE, 0, &rg_gh);
+		if (error)
+			goto out_norgrp;
+
+		gfs2_unlink_di(&ip->i_inode); /* mark inode unlinked */
+		gfs2_glock_dq_uninit(&rg_gh);
+	}
+
+out_norgrp:
+	if (!existing)
+		gfs2_glock_dq_uninit(&ri_gh);
+out:
+	return error;
+}
+
 /**
  * gfs2_change_nlink - Change nlink count on inode
  * @ip: The GFS2 inode
@@ -326,50 +370,6 @@
 	return error;
 }
 
-int gfs2_change_nlink_i(struct gfs2_inode *ip)
-{
-	struct gfs2_sbd *sdp = ip->i_inode.i_sb->s_fs_info;
-	struct gfs2_inode *rindex = GFS2_I(sdp->sd_rindex);
-	struct gfs2_glock *ri_gl = rindex->i_gl;
-	struct gfs2_rgrpd *rgd;
-	struct gfs2_holder ri_gh, rg_gh;
-	int existing, error;
-
-	/* if we come from rename path, we could have the lock already */
-	existing = gfs2_glock_is_locked_by_me(ri_gl);
-	if (!existing) {
-		error = gfs2_rindex_hold(sdp, &ri_gh);
-		if (error)
-			goto out;
-	}
-
-	/* find the matching rgd */
-	error = -EIO;
-	rgd = gfs2_blk2rgrpd(sdp, ip->i_num.no_addr);
-	if (!rgd)
-		goto out_norgrp;
-
-	/*
-	 * Eventually we may want to move rgd(s) to a linked list
-	 * and piggyback the free logic into one of gfs2 daemons
-	 * to gain some performance.
-	 */
-	if (!rgd->rd_gl || !gfs2_glock_is_locked_by_me(rgd->rd_gl)) {
-		error = gfs2_glock_nq_init(rgd->rd_gl, LM_ST_EXCLUSIVE, 0, &rg_gh);
-		if (error)
-			goto out_norgrp;
-
-		gfs2_unlink_di(&ip->i_inode); /* mark inode unlinked */
-		gfs2_glock_dq_uninit(&rg_gh);
-	}
-
-out_norgrp:
-	if (!existing)
-		gfs2_glock_dq_uninit(&ri_gh);
-out:
-	return error;
-}
-
 struct inode *gfs2_lookup_simple(struct inode *dip, const char *name)
 {
 	struct qstr qstr;


  parent reply	other threads:[~2007-01-13  9:56 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12  6:26 2.6.20-rc4-mm1 Andrew Morton
2007-01-12 10:20 ` Early ACPI lockup (was Re: 2.6.20-rc4-mm1) Frederik Deweerdt
2007-01-12 22:53   ` Len Brown
2007-01-12 23:10     ` Frederik Deweerdt
2007-01-12 23:36       ` Jiri Slaby
2007-01-13  0:08         ` Michal Piotrowski
2007-01-13  0:45           ` Frederik Deweerdt
2007-01-13  0:43         ` Jiri Slaby
2007-01-12 10:25 ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 13:18   ` 2.6.20-rc4-mm1 Frederik Deweerdt
2007-01-12 15:13     ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 15:16       ` 2.6.20-rc4-mm1 Michal Piotrowski
2007-01-12 16:12         ` 2.6.20-rc4-mm1 Mariusz Kozlowski
2007-01-12 10:52 ` 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1) Sander
2007-01-12 11:28   ` Paul Jackson
2007-01-12 19:25     ` Christoph Lameter
2007-01-12 21:20       ` Paul Jackson
2007-01-12 21:28         ` Christoph Lameter
2007-01-12 21:58           ` Paul Jackson
2007-01-12 22:00             ` Christoph Lameter
2007-01-12 22:10               ` Paul Jackson
2007-01-12 22:11               ` Andrew Morton
2007-01-12 11:55 ` spurious sparse warnings from linux/aio.h (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-12 13:11   ` Suparna Bhattacharya
2007-01-12 17:46     ` spurious sparse warnings from linux/aio.h Tilman Schmidt
2007-01-12 13:33 ` [-mm patch] remove tcp header from tcp_v4_check Frederik Deweerdt
2007-01-12 13:55   ` [-mm patch] remove tcp header from tcp_v4_check (take #2) Frederik Deweerdt
2007-02-05  0:44     ` David Miller
2007-01-13  7:27 ` 2.6.20-rc4-mm1: status of sn9c102_pas202bca? Adrian Bunk
2007-01-15 11:34   ` Mauro Carvalho Chehab
2007-01-13  9:56 ` [-mm patch] make mmc_sysfs.c:mmc_key_type static Adrian Bunk
2007-01-13 22:38   ` Pierre Ossman
2007-01-13  9:56 ` Adrian Bunk [this message]
2007-01-15 10:31   ` [-mm patch] make gfs2_change_nlink_i() static Steven Whitehouse
2007-01-16 21:04   ` [Cluster-devel] " Wendy Cheng
2007-01-16 21:29     ` Adrian Bunk
2007-01-14  9:10 ` 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO Adrian Bunk
2007-01-14 14:36   ` David Brownell
2007-02-20  0:06     ` Adrian Bunk
2007-03-29 22:06       ` Randy Dunlap
2007-03-29 22:24         ` David Brownell
2007-05-08 22:17           ` [PATCH] " Randy Dunlap
2007-05-08 22:34             ` David Brownell
2007-05-08 22:37             ` Greg KH
2007-03-30 15:18         ` 2.6.20-rc4-mm1: " Tony Olech
2007-01-14  9:48 ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 10:46   ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 14:40     ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:05       ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:31         ` 2.6.20-rc4-mm1 Thomas Gleixner
2007-01-14 22:30           ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-15  8:22             ` 2.6.20-rc4-mm1 Ingo Molnar
2007-01-15 23:55               ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 22:20       ` 2.6.20-rc4-mm1 Jens Axboe
2007-01-14 23:52 ` i810fb fails to load (was: 2.6.20-rc4-mm1) Tilman Schmidt
2007-01-15  0:22   ` Andrew Morton
2007-01-22 13:42     ` i810fb fails to load Thomas Hellström
2007-01-22 18:30       ` Tilman Schmidt
2007-01-22 21:50       ` Dave Airlie
2007-01-23  8:10         ` Thomas Hellström
2007-01-18 21:55 ` [-mm patch] fs/unionfs/: possible cleanups Adrian Bunk
2007-01-20 22:06   ` Josef Sipek
2007-01-19 18:40 ` [-mm patch] drivers/mtd/ubi/: " Adrian Bunk
2007-01-21 11:23   ` Artem Bityutskiy
2007-01-20 22:38 ` [-mm patch] oops in drivers/net/shaper.c Frederik Deweerdt
2007-01-21 19:13 ` [-mm patch] remove one remaining "#define BCM_TSO 1" Adrian Bunk
2007-01-22 18:17 ` [-mm patch] drivers/firewire/: cleanups Adrian Bunk
2007-01-22 19:41   ` Kristian Høgsberg
2007-01-22 20:04     ` Adrian Bunk
2007-01-22 20:04       ` Kristian Høgsberg
2007-01-22 20:44         ` Stefan Richter
2007-01-23  6:02 ` `make htmldocs` fails Don Mullis
2007-01-23  6:22   ` Randy Dunlap
2007-01-23  6:45     ` `make htmldocs` fails -- 2.6.20-rc4-mm1 Don Mullis
2007-01-23  6:35   ` `make htmldocs` fails Greg KH
2007-01-24 13:53 ` 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Adrian Bunk
2007-01-24 14:12   ` Sergei Shtylyov
2007-02-17 19:26     ` Sergei Shtylyov
2007-02-17 19:32       ` Sergei Shtylyov
2007-02-26 13:22         ` Sergei Shtylyov
2007-02-26 17:26           ` Randy Dunlap
2007-02-26 21:14             ` Greg KH
2007-03-06 16:15               ` Sergei Shtylyov
2007-03-06 16:47                 ` Randy Dunlap
2007-03-09 12:54                   ` Tejun Heo
2007-01-24 22:36 ` [-mm patch] MTD_CK804XROM must depend on PCI Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070113095640.GK7469@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox