From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch 2/3] Scheduled removal of SA_xxx interrupt flags fixups
Date: Sun, 14 Jan 2007 13:42:52 +0100 [thread overview]
Message-ID: <20070114124252.GA4809@elte.hu> (raw)
In-Reply-To: <20070114081926.967534281@inhelltoy.tec.linutronix.de>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> The obsolete SA_xxx interrupt flags have been used despite the
> scheduled removal. Fixup the remaining users.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
i have tested your patch-queue ontop of rc4-mm1 (trivial reject fixups
are below), it builds and boots fine.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
---
drivers/char/nozomi.c | 2 +-
drivers/net/qla3xxx.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Index: linux/drivers/char/nozomi.c
===================================================================
--- linux.orig/drivers/char/nozomi.c
+++ linux/drivers/char/nozomi.c
@@ -1378,7 +1378,7 @@ static int nozomi_setup_interrupt(struct
{
int rval;
- rval = request_irq(dc->pdev->irq, &interrupt_handler, SA_SHIRQ,
+ rval = request_irq(dc->pdev->irq, &interrupt_handler, IRQF_SHARED,
NOZOMI_NAME, dc);
if (rval)
dev_err(&dc->pdev->dev, "Cannot open because IRQ %d "
Index: linux/drivers/net/qla3xxx.c
===================================================================
--- linux.orig/drivers/net/qla3xxx.c
+++ linux/drivers/net/qla3xxx.c
@@ -2999,7 +2999,7 @@ static int ql_adapter_up(struct ql3_adap
{
struct net_device *ndev = qdev->ndev;
int err;
- unsigned long irq_flags = SA_SAMPLE_RANDOM | SA_SHIRQ;
+ unsigned long irq_flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
unsigned long hw_flags;
if (ql_alloc_mem_resources(qdev)) {
@@ -3018,7 +3018,7 @@ static int ql_adapter_up(struct ql3_adap
} else {
printk(KERN_INFO PFX "%s: MSI Enabled...\n", qdev->ndev->name);
set_bit(QL_MSI_ENABLED,&qdev->flags);
- irq_flags &= ~SA_SHIRQ;
+ irq_flags &= ~IRQF_SHARED;
}
}
next prev parent reply other threads:[~2007-01-14 12:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 8:33 [patch 0/3] Scheduled removal of SA_xxx interrupt flags Thomas Gleixner
2007-01-14 8:33 ` [patch 1/3] " Thomas Gleixner
2007-01-23 20:02 ` Andrew Morton
2007-01-23 20:31 ` Thomas Gleixner
2007-04-06 13:49 ` [PATCH] Deprecate SA_xxx interrupt flags -V2 Thomas Gleixner
2007-04-06 19:22 ` Andrew Morton
2007-04-06 19:29 ` Ingo Molnar
2007-04-06 19:36 ` Thomas Gleixner
2007-04-06 20:03 ` [PATCH] Replace deprecated SA_xxx interrupt flags Thomas Gleixner
2007-04-06 20:08 ` [PATCH-mm] Replace more " Thomas Gleixner
2007-01-14 8:33 ` [patch 2/3] Scheduled removal of SA_xxx interrupt flags fixups Thomas Gleixner
2007-01-14 12:42 ` Ingo Molnar [this message]
2007-01-14 14:25 ` Thomas Gleixner
2007-01-14 14:25 ` Ingo Molnar
2007-01-14 8:33 ` [patch-mm 3/3] Scheduled removal of SA_xxx interrupt flags fixups 2 (mm) Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070114124252.GA4809@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox