Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

Dave Airlie
2007-01-14T19:31:06Z

On 1/15/07, Arjan van de Ven <arjan@infradead.org> wrote:
> On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
> > Substitue intel_rng magic PCI IDs values used in the IDs table
> > with the macros defined in pci_ids.h
> >
> Hi,
>
>
> hmm this is actually the opposite direction than most of the kernel is
> heading in, mostly because the pci_ids.h file is a major maintenance
> pain.
>
> Afaik the current "rule" is: if a PCI ID is only used in one driver, use
> the numeric value and not (add) a symbolic constant.
>

My guess is that the RNG is on the LPC so the values are used in a few places..

Dave.