From: Ben Dooks <ben-linux@fluff.org>
To: rpurdie@rpsys.net, linux-kernel@vger.kernel.org
Subject: LEDS: S3C24XX generate name if none given
Date: Mon, 15 Jan 2007 12:26:54 +0000 [thread overview]
Message-ID: <20070115122654.GA25047@home.fluff.org> (raw)
Generate a name if none is passed to the S3C24XX GPIO LED driver.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
diff -urpN -X ../dontdiff linux-2.6.19/drivers/leds/leds-s3c24xx.c linux-2.6.19-simtec1p22/drivers/leds/leds-s3c24xx.c
--- linux-2.6.19/drivers/leds/leds-s3c24xx.c 2006-11-29 21:57:37.000000000 +0000
+++ linux-2.6.19-simtec1p22/drivers/leds/leds-s3c24xx.c 2007-01-04 10:22:58.000000000 +0000
@@ -23,6 +23,8 @@
/* our context */
struct s3c24xx_gpio_led {
+ char name[32];
+
struct led_classdev cdev;
struct s3c24xx_led_platdata *pdata;
};
@@ -85,6 +87,14 @@ static int s3c24xx_led_probe(struct plat
led->pdata = pdata;
+ /* create name if we where not passed one */
+
+ if (led->cdev.name == NULL) {
+ snprintf(led->name, sizeof(led->name), "%s.%d",
+ dev->name, dev->id);
+ led->cdev.name = led->name;
+ }
+
/* no point in having a pull-up if we are always driving */
if (pdata->flags & S3C24XX_LEDF_TRISTATE) {
next reply other threads:[~2007-01-15 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 12:26 Ben Dooks [this message]
2007-01-15 12:32 ` LEDS: S3C24XX generate name if none given Robert P. J. Day
2007-01-15 13:44 ` Richard Purdie
2007-01-15 15:42 ` Ben Dooks
2007-01-16 19:06 ` Richard Purdie
2007-01-22 19:56 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115122654.GA25047@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox