Re: [PATCH 1/11] Fix CONFIG_COMPAT_VDSO

Al Boldi
2007-01-15T11:58:38Z

Roland McGrath wrote:
>
> I wouldn't mind if CONFIG_COMPAT_VDSO went away entirely.
> But if it's there, it should work properly. Currently
> it's quite haphazard: both real vma and fixmap are
> mapped, both are put in the two different AT_* slots,
> sysenter returns to the vma address rather than the
> fixmap address, and core dumps yet are another story.
>
> This patch makes CONFIG_COMPAT_VDSO disable the real vma
> and use the fixmap area consistently. This makes it
> actually compatible with what the old vdso implementation did.

I just tried your patch, but your changes seem to revert performance
improvements achieved with 2.6.19, when vdso_enabled=1 and
randomize_va_space=0.

Thanks!

--
Al