Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

[Vojtech Pavlik <vojtech@suse.cz>]

On Mon, Jan 15, 2007 at 05:44:26PM +0100, Jiri Kosina wrote:
> On Mon, 15 Jan 2007, Simon Budig wrote:
> 
> > > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel 
> > > (this is where the USBHID split happened and generic HID layer was 
> > > introduced). Could you please rebase it against newer version of kernel 
> > > and resend it?
> > I've updated the patch, will submit it to the list in a few minutes.
> 
> I got it, thanks.
> 
> > > All your changes happen to be in the transport-independent code, so it 
> > > seems that this would be rather trivial task - probably only pathnames 
> > > (and diff offsets) will change - your changes should now go to 
> > > drivers/hid/hid-*, not drivers/usb/input/hid-*.
> > Yeah, it was easy to port over. Did the hid-debug stuff disappear
> > completely? What would I use instead?
> 
> No, it didn't disappear, it was just moved to include/linux/hid-debug.h. 

Do you think that makes sense? It's code, not a header file.

> Should I wait for an updated patch that uses hid-debug.h again?

-- 
Vojtech Pavlik
Director SuSE Labs