From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: grundler@parisc-linux.org, akpm@osdl.org, greg@kroah.com,
kaneshige.kenji@jp.fujitsu.com, linux-kernel@vger.kernel.org,
seto.hidetoshi@jp.fujitsu.com
Subject: Re: patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree
Date: Wed, 17 Jan 2007 11:21:15 -0800 [thread overview]
Message-ID: <20070117192114.GB14485@suse.de> (raw)
In-Reply-To: <45ADE7CB.2080701@gmail.com>
On Wed, Jan 17, 2007 at 10:09:08AM +0059, Jiri Slaby wrote:
> gregkh@suse.de wrote:
> [...]
> > +Tips on when/where to use the above attributes:
> > + o The module_init()/module_exit() functions (and all
> > + initialization functions called _only_ from these)
> > + should be marked __init/__exit.
> > +
> > + o Do not mark the struct pci_driver.
> > +
> > + o The ID table array should be marked __devinitdata.
>
> Is that correct? It panics somewehere IIRC?
If it's marked __initdata it can panic if we try to access the data when
adding a new PCI device after the system is up and running (pci hotplug
or dynamic pci ids support.) That's why it needs to be either no
marking or __devinitdata (which resolves to nothing if CONFIG_HOTPLUG is
enabled.)
thanks,
greg k-h
prev parent reply other threads:[~2007-01-17 19:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 8:05 [PATCH 1/5] Update Documentation/pci.txt Hidetoshi Seto
2006-11-22 8:54 ` Arjan van de Ven
2006-11-22 18:28 ` Grant Grundler
2006-11-24 0:38 ` Hidetoshi Seto
2006-11-24 5:12 ` Grant Grundler
2006-11-24 6:05 ` Hidetoshi Seto
2006-12-06 7:26 ` Greg KH
2006-12-07 3:55 ` Grant Grundler
2006-12-10 7:25 ` Grant Grundler
2006-12-15 17:02 ` Greg KH
2006-12-18 7:11 ` Grant Grundler
2006-12-22 19:46 ` Randy Dunlap
2006-12-22 21:52 ` Stefan Richter
2006-12-24 6:11 ` Grant Grundler
2006-12-24 6:07 ` [PATCH] Update Documentation/pci.txt v7 Grant Grundler
2006-12-24 19:16 ` Randy Dunlap
2006-12-25 7:59 ` Grant Grundler
2006-12-25 8:06 ` Grant Grundler
2006-12-25 8:08 ` Grant Grundler
2007-01-02 21:45 ` Greg KH
2007-01-03 7:15 ` Grant Grundler
2006-12-25 9:04 ` Kenji Kaneshige
2007-01-16 22:26 ` patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree gregkh
2007-01-17 9:10 ` Jiri Slaby
2007-01-17 19:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117192114.GB14485@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=jirislaby@gmail.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox