From: Adrian Bunk <bunk@stusta.de>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
Date: Mon, 22 Jan 2007 16:38:13 +0100 [thread overview]
Message-ID: <20070122153813.GT9093@stusta.de> (raw)
In-Reply-To: <20070122151841.6d0473e4@localhost.localdomain>
On Mon, Jan 22, 2007 at 03:18:41PM +0000, Alan wrote:
> On Sun, 21 Jan 2007 20:13:00 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > Using assembler code for performance in drivers might have been a good
> > idea 15 years ago when this code was written, but with today's compilers
> > that's unlikely to be an advantage.
> >
> > Besides this, it also hurts the readability.
> >
> > Simply use the C code that was already there as an alternative.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> "stosb\n\t"
>
> NAK
>
> The C codepaths are essentially untested on this driver.
Has any part of this driver ever be tested with kernel 2.6?
Or compiled with gcc 4?
> Alan
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-01-22 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-21 19:13 [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM Adrian Bunk
2007-01-22 15:18 ` Alan
2007-01-22 15:38 ` Adrian Bunk [this message]
2007-01-22 15:53 ` Alan
-- strict thread matches above, loose matches on Subject: below --
2007-01-06 1:06 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070122153813.GT9093@stusta.de \
--to=bunk@stusta.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox