Re: [patch 03/26] Dynamic kernel command-line - arm

Russell King
2007-01-23T11:54:17Z

On Tue, Jan 23, 2007 at 01:31:25PM +0200, Alon Bar-Lev wrote:
> On 1/23/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> >> So it will be fine if I initialize it to "" and remove the static from
> >> the your example?
> >
> >Why do you want to remove the static?
>
> Rossell, I am confused.
> There are many places in kernel where there is static __initdata
> without initialization. Should all these be corrected too? Or your
> comment applies only to none static global data?

>From what I remembered from previous mails on this list (which is what
caused me to pick up on this), and what I later quoted from the gcc
manual, all those places (where something is marked __initdata but is
not explicitly initialised) would appear to be incorrect.

So they should probably be fixed up.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/