Re: [PATCH 04/12] clocksource: avr32 initialize list value

Haavard Skinnemoen
2007-01-23T13:45:18Z

On Tue, 23 Jan 2007 05:02:49 -0800
Daniel Walker <dwalker@mvista.com> wrote:

> On Tue, 2007-01-23 at 13:42 +0100, Haavard Skinnemoen wrote:
> > On 1/23/07, Daniel Walker <dwalker@mvista.com> wrote:
> > > Update arch/avre32/ with list initialization.
> > >
> > > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> >
> > Looks good to me, although I suppose it wouldn't hurt to include
> > <linux/list.h> as well since there seems to be an ongoing effort to
> > reduce the number of files that are included implicitly through other
> > headers. Might save us from some trouble later.
>
> It shouldn't be outright implicit since it's included in clocksource.h .
> That has to be included before you can create a clocksource. I could see
> adding list.h if it wasn't clear which include was bringing it in.

Ah, of course. Just disregard that suggestion, then.

> > I've closed your support request, so you shouldn't expect a reply from
> > avr32@atmel.com (I was going to reply through the support system, but
> > I couldn't figure out how to prevent it from top-quoting.) Probably
> > best if you send patches directly to me at hskinnemoen@atmel.com, but
> > the support address is a nice fallback if I'm unable to respond for
> > some reason.
>
> I got that address from the maintainers file,
>
> AVR32 ARCHITECTURE
> P: Atmel AVR32 Support Team
> M: avr32@atmel.com
> P: Haavard Skinnemoen
> M: hskinnemoen@atmel.com
> W: http://www.atmel.com/products/AVR32/
> W: http://avr32linux.org/
> W: http://avrfreaks.net/
> S: Supported
>
> I just picked the top address .. If it makes sense you might want to
> consider dropping that address from the maintainers file. It seems a
> little formal for submitting patches. In the future I'll send them to
> you.

Right. I guess we should at least switch the order so that I'm the
first one on the list. I'll have a chat with the support guys, maybe we
should just drop that address from MAINTAINERS.

Håvard