From: Andrew Morton <akpm@osdl.org>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hansjoerg Lipp <hjlipp@web.de>
Subject: Re: [PATCH 2.6.20-rc5] Gigaset ISDN driver error handling fixes
Date: Tue, 23 Jan 2007 22:47:42 -0800 [thread overview]
Message-ID: <20070123224742.4b13b2ea.akpm@osdl.org> (raw)
In-Reply-To: <20070117174213.A39123427B1@gx110.ts.pxnet.com>
On Wed, 17 Jan 2007 18:42:13 +0100 (CET)
Tilman Schmidt <tilman@imap.cc> wrote:
> + mutex_init(&cs->mutex);
> + mutex_lock(&cs->mutex);
I have vague memories of making rude comments about this a few months ago.
It is very weird to lock a mutex just after intialising it. I mean, if any other
thread can lock this mutex then there's a race. If no other thread can
lock it, then this thread doesn't need to either.
next parent reply other threads:[~2007-01-24 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070117174213.A39123427B1@gx110.ts.pxnet.com>
2007-01-24 6:47 ` Andrew Morton [this message]
2007-01-26 16:29 ` [PATCH 2.6.20-rc5] Gigaset ISDN driver error handling fixes Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123224742.4b13b2ea.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox