From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932812AbXAXV3U (ORCPT ); Wed, 24 Jan 2007 16:29:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752084AbXAXV3U (ORCPT ); Wed, 24 Jan 2007 16:29:20 -0500 Received: from cantor.suse.de ([195.135.220.2]:50336 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085AbXAXV3T (ORCPT ); Wed, 24 Jan 2007 16:29:19 -0500 Date: Wed, 24 Jan 2007 13:28:24 -0800 From: Greg KH To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linux Containers , linux-fsdevel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 2/2] Implement shadow directory support for device classes. Message-ID: <20070124212824.GA29981@suse.de> References: <20070124195017.GA27315@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2007 at 01:28:22PM -0700, Eric W. Biederman wrote: > Greg KH writes: > > > On Wed, Jan 24, 2007 at 12:37:19PM -0700, Eric W. Biederman wrote: > >> > >> Modify the device class code so that normal manipulations work > >> in the presence of shadow directories. Some of the shadow directory > >> support still needs to be implemented in the implementation of the > >> class but these modifications are sufficient to make that simple. > > > > This is a nice idea, but I'm working to get rid of 'struct class_device' > > from the tree. Network devices have already been converted, the patch > > is in the -mm tree, I'm working on some firewire fixes before pushing it > > to Linus. > > > > So, I think you want to do this work for 'struct device' too, as that is > > what will be the real user of this code. > > Sure. That shouldn't be too hard. > > Is any of that work in Dave Millers' networking tree? No, it's in my tree, and in -mm. It's all in one patch at: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/network-device.patch if you want to try it out. Or you can try it with any of the subsystems that have already been converted over to use the struct device code, like misc, mem, and many others. Just look for the symlinks in /sys/class/CLASS_NAME/ instead of real subdirectories. So I'd really prefer to not apply this patch, and just do this kind of work for 'struct device' instead. The first one looks fine, I'll add it to my queue. thanks, greg k-h