From: Andrew Morton <akpm@osdl.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Oleg Nesterov <oleg@tv-sign.ru>,
Cedric Le Goater <clg@fr.ibm.com>,
Daniel Hokka Zakrisson <daniel@hozac.com>,
herbert@13thfloor.at, trond.myklebust@fys.uio.no,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] namespaces: fix exit race by splitting exit
Date: Thu, 25 Jan 2007 22:30:56 -0800 [thread overview]
Message-ID: <20070125223056.c77b0e97.akpm@osdl.org> (raw)
In-Reply-To: <20070126052659.GA23250@sergelap.austin.ibm.com>
On Thu, 25 Jan 2007 23:26:59 -0600
"Serge E. Hallyn" <serue@us.ibm.com> wrote:
> Fix exit race by splitting the nsproxy putting into two pieces.
> First piece reduces the nsproxy refcount. If we dropped the last
> reference, then it puts the mnt_ns, and returns the nsproxy as a
> hint to the caller. Else it returns NULL. The second piece of
> exiting task namespaces sets tsk->nsproxy to NULL, and drops the
> references to other namespaces and frees the nsproxy only if an
> nsproxy was passed in.
>
> A little awkward and should probably be reworked, but hopefully
> it fixes the NFS oops.
I'm a bit worried about jamming something like this into 2.6.20. Could the
usual culprits please review this carefully with some urgency?
And Daniel, if you can find time to runtime test it please?
next prev parent reply other threads:[~2007-01-26 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 5:26 [PATCH] namespaces: fix exit race by splitting exit Serge E. Hallyn
2007-01-26 6:30 ` Andrew Morton [this message]
2007-01-30 2:42 ` Herbert Poetzl
2007-01-30 3:00 ` Serge E. Hallyn
2007-01-26 6:36 ` Andrew Morton
2007-01-26 10:09 ` Daniel Hokka Zakrisson
2007-01-26 10:23 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070125223056.c77b0e97.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=daniel@hozac.com \
--cc=ebiederm@xmission.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=serue@us.ibm.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox