Re: mm snapshot broken-out-2007-01-26-00-36.tar.gz uploaded

Andrew Morton
2007-01-27T21:41:21Z

On Sat, 27 Jan 2007 22:29:40 +0100
Tilman Schmidt <tilman@imap.cc> wrote:

> Am 27.01.2007 17:37 schrieb Michal Piotrowski:
> > On 26/01/07, akpm@osdl.org <akpm@osdl.org> wrote:
> >> The mm snapshot broken-out-2007-01-26-00-36.tar.gz has been uploaded to
> >>
> >> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-01-26-00-36.tar.gz
> >>
> >
> > It's probably not mm snapshot related. This driver is just broken.
>
> It probably *is* mm snapshot related. This driver compiles and works
> just fine in 2.6.19.2, 2.6.20-rc6 and 2.6.20-rc4-mm1.
>
> > drivers/isdn/gigaset/bas-gigaset.c: In function 'dump_urb':
> > drivers/isdn/gigaset/bas-gigaset.c:258: error: 'struct urb' has no
> > member named 'bandwidth'
>
> In current stable and mm releases, 'struct urb' *does* have a member
> named 'bandwidth'. If some mm patch removes that member then it is
> the responsibility of that patch to adapt all users of that structure
> accordingly.
>

yup, there's a patch in Greg's USB tree which removes the bandwidth field.
Mostly. I fixed it up.

I have everything compiling now, mostly. The number of fixes which were
needed was just extraordinary. I'm thinking about making changes...