Re: [PATCH] alsa: correct nonsensical sysfs device symlinks

Pierre Ossman
2007-01-25T11:27:46Z

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

Christopher "Monty" Montgomery wrote:
> This patch was generated against 2.6.20-rc5; it fixes a bug that
> cropped up in a late 2.6.19-mm kernel.
>
> When ALSA's sysfs device creation was converted from using
> class_device_create() to device_create(), the fourth param from
> class_device_create() [dev] was simply plugged into arg 2 of
> device_create(). This causes the device symlinks under all the
> class/sound/[node] to point to nonsensical places. Among other
> problems, this breaks HAL and all audio software that depends on HAL.
>

There are no device symlinks anymore, so the current behaviour seems
correct. HAL should follow the symlink, then move up in the device tree
to find a suitable parent.

Rgds
Pierre

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]