Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

xiphmont
2007-01-25T18:51:45Z

On 1/25/07, Takashi Iwai <tiwai@suse.de> wrote:

> > [This does beg the question: Does the benefit of this complete
> > restructuring in a subminor release of an allegedly stable kernel
> > outweigh the fact that it breaks all audio for any user running a
> > gnome desktop?]
>
> Well, that's not me who introduced that ;)

Consider it addressed to those responsible.

> Also, avoid creating card* instance. It makes no sense in that case.

Well, the 'new' entries don't interfere with old-- and we inevitably
are going to end up with a situation where some software can only read
the 'new' entries and some software can only read the 'old', otherwise
why offer compatability at all? I interpreted the
CONFIG_SYSFS_DEPRECATED option to mean 'also offer the deprecated
entries in addition to the new structure', otherwise the name should
be CONFIG_SYSFS_OLDSTYLE or some such to imply they're mutually
exclusive....

> (So... what's wrong with my patch?)

As it turns out, nothing (I made some error somewhere initially when
testing it).
Apologies if I wasn't clear.

(Well, it's incomplete like my original patch was in that it only
changed the device symlinks for controlX and pcmX; the other entries
still had device entries pointing at card*).

Monty