public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Alexey Dobriyan <adobriyan@openvz.org>,
	devel@openvz.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] lutimesat: simplify utime(2)
Date: Sat, 27 Jan 2007 00:35:42 +0100	[thread overview]
Message-ID: <200701270035.42323.arnd@arndb.de> (raw)
In-Reply-To: <20070126124120.f8f78623.akpm@osdl.org>

On Friday 26 January 2007 21:41, Andrew Morton wrote:
> I'm somewhat surprised that this wasn't done earlier.  I wonder if there's
> some subtle reason why this won't work.   How well tested is this?

http://www.opengroup.org/onlinepubs/000095399/functions/utimes.html
lists a slight difference between utime and utimes in the handling
of EPERM/EACCESS:

> The utimes() function shall fail if:
> [EACCES] Search permission is denied by a component of the path prefix;
>  or the times argument is a null pointer and the effective user ID of the
>  process does not match the owner of the file and write access is denied.
> [EPERM] The times argument is not a null pointer and the calling process'
>  effective user ID has write access to the file but does not match the
>  owner of the file and the calling process does not have the appropriate
>  privileges.
>
> The utime() function shall fail if:
> [EACCES]  Search permission is denied by a component of the path prefix;
>  or the times argument is a null pointer and the effective user ID of the
>  process does not match the owner of the file, the process does not have
>  write permission for the file, and the process does not have appropriate
>  privileges.
> [EPERM] The times argument is not a null pointer and the calling process'
>  effective user ID does not match the owner of the file and the calling
>  process does not have the appropriate privileges.

I don't really understand how that should be implemented in different
ways, but it might be the reason that we have separate functions.

	Arnd <><

  reply	other threads:[~2007-01-26 23:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26 11:21 [PATCH 1/3] lutimesat: simplify utime(2) Alexey Dobriyan
2007-01-26 20:41 ` Andrew Morton
2007-01-26 23:35   ` Arnd Bergmann [this message]
2007-01-28 15:28     ` Alexey Dobriyan
2007-01-28 15:24   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701270035.42323.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=adobriyan@openvz.org \
    --cc=akpm@osdl.org \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox